doc: fix errors in Web Streams doc by Y1D7NG · Pull Request #42862 · nodejs/node

Y1D7NG · 2022-04-25T06:45:14Z

fix typo.
replace transform.writable with destination in readableStream.pipeTo(destination, options) options description.

doc/api/webstreams.md

nodejs-github-bot · 2022-05-02T23:13:23Z

Commit Queue failed

- Loading data for nodejs/node/pull/42862
FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close
    at consumeBody (file:///opt/hostedtoolcache/node/16.14.2/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Response.text (file:///opt/hostedtoolcache/node/16.14.2/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18)
    at async Request.json (file:///opt/hostedtoolcache/node/16.14.2/x64/lib/node_modules/node-core-utils/lib/request.js:51:18)
    at async Request.query (file:///opt/hostedtoolcache/node/16.14.2/x64/lib/node_modules/node-core-utils/lib/request.js:109:20)
    at async Request.queryAll (file:///opt/hostedtoolcache/node/16.14.2/x64/lib/node_modules/node-core-utils/lib/request.js:136:20)
    at async Request.gql (file:///opt/hostedtoolcache/node/16.14.2/x64/lib/node_modules/node-core-utils/lib/request.js:66:22)
    at async PRData.getComments (file:///opt/hostedtoolcache/node/16.14.2/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21)
    at async Promise.all (index 2)
    at async Promise.all (index 1) {
  type: 'system',
  errno: 'ERR_STREAM_PREMATURE_CLOSE',
  code: 'ERR_STREAM_PREMATURE_CLOSE',
  erroredSysCall: undefined
}

https://github.com/nodejs/node/actions/runs/2260945403

nodejs-github-bot · 2022-05-02T23:26:06Z

Commit Queue failed

- Loading data for nodejs/node/pull/42862 ✔ Done loading data for nodejs/node/pull/42862 ----------------------------------- PR info ------------------------------------ Title doc: fix errors in Web Streams doc (#42862) Author OneNail (@OneNail) Branch OneNail:doc-webstream -> nodejs:master Labels doc Commits 5 - doc: fix errors in Web Streams doc - doc: fix typo - Update doc/api/webstreams.md - Update doc/api/webstreams.md - Update doc/api/webstreams.md Committers 2 - OneNail - GitHub PR-URL: https://github.com/nodejs/node/pull/42862 Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Mestery Reviewed-By: Harshitha K P Reviewed-By: Akhil Marsonya Reviewed-By: Zeyu Yang Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42862 Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Mestery Reviewed-By: Harshitha K P Reviewed-By: Akhil Marsonya Reviewed-By: Zeyu Yang Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 25 Apr 2022 06:45:14 GMT ✔ Approvals: 7 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42862#pullrequestreview-952311635 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42862#pullrequestreview-952482047 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42862#pullrequestreview-953269826 ✔ - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/42862#pullrequestreview-953674890 ✔ - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/42862#pullrequestreview-953821822 ✔ - Zeyu Yang (@himself65): https://github.com/nodejs/node/pull/42862#pullrequestreview-957158392 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42862#pullrequestreview-959574283 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 42862 From https://github.com/nodejs/node * branch refs/pull/42862/merge -> FETCH_HEAD ✔ Fetched commits as f6f95bf61e84..887ef9ec9b6a -------------------------------------------------------------------------------- [master 5347d5e3b4] doc: fix errors in Web Streams doc Author: OneNail Date: Mon Apr 25 14:24:10 2022 +0800 1 file changed, 6 insertions(+), 7 deletions(-) [master 8cad95eee8] doc: fix typo Author: OneNail Date: Mon Apr 25 15:36:25 2022 +0800 1 file changed, 4 insertions(+), 4 deletions(-) [master 740821baa7] Update doc/api/webstreams.md Author: Rich Trott Date: Mon May 2 14:15:01 2022 -0700 1 file changed, 1 insertion(+), 1 deletion(-) [master eb0bd6302b] Update doc/api/webstreams.md Author: Rich Trott Date: Mon May 2 14:15:33 2022 -0700 1 file changed, 1 insertion(+), 1 deletion(-) [master f4fe55fe74] Update doc/api/webstreams.md Author: Rich Trott Date: Mon May 2 14:15:56 2022 -0700 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 5 commits in the PR. Attempting autorebase. Rebasing (2/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: fix errors in Web Streams doc

PR-URL: #42862
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Harshitha K P harshitha014@gmail.com
Reviewed-By: Akhil Marsonya akhil.marsonya27@gmail.com
Reviewed-By: Zeyu Yang himself65@outlook.com
Reviewed-By: Rich Trott rtrott@gmail.com

[detached HEAD 3f0ea992da] doc: fix errors in Web Streams doc
Author: OneNail OneNail@yeah.net
Date: Mon Apr 25 14:24:10 2022 +0800
1 file changed, 6 insertions(+), 7 deletions(-)
Rebasing (3/10)
Rebasing (4/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: fix typo

PR-URL: #42862
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Harshitha K P harshitha014@gmail.com
Reviewed-By: Akhil Marsonya akhil.marsonya27@gmail.com
Reviewed-By: Zeyu Yang himself65@outlook.com
Reviewed-By: Rich Trott rtrott@gmail.com

[detached HEAD b47391e56a] doc: fix typo
Author: OneNail OneNail@yeah.net
Date: Mon Apr 25 15:36:25 2022 +0800
1 file changed, 4 insertions(+), 4 deletions(-)
Rebasing (5/10)
Rebasing (6/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/webstreams.md

PR-URL: #42862
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Harshitha K P harshitha014@gmail.com
Reviewed-By: Akhil Marsonya akhil.marsonya27@gmail.com
Reviewed-By: Zeyu Yang himself65@outlook.com
Reviewed-By: Rich Trott rtrott@gmail.com

[detached HEAD fa09b4fd5d] Update doc/api/webstreams.md
Author: Rich Trott rtrott@gmail.com
Date: Mon May 2 14:15:01 2022 -0700
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (7/10)
Rebasing (8/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/webstreams.md

PR-URL: #42862
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Harshitha K P harshitha014@gmail.com
Reviewed-By: Akhil Marsonya akhil.marsonya27@gmail.com
Reviewed-By: Zeyu Yang himself65@outlook.com
Reviewed-By: Rich Trott rtrott@gmail.com

[detached HEAD 7b8933f891] Update doc/api/webstreams.md
Author: Rich Trott rtrott@gmail.com
Date: Mon May 2 14:15:33 2022 -0700
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (9/10)
Rebasing (10/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/webstreams.md

PR-URL: #42862
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Harshitha K P harshitha014@gmail.com
Reviewed-By: Akhil Marsonya akhil.marsonya27@gmail.com
Reviewed-By: Zeyu Yang himself65@outlook.com
Reviewed-By: Rich Trott rtrott@gmail.com

[detached HEAD d2fd767897] Update doc/api/webstreams.md
Author: Rich Trott rtrott@gmail.com
Date: Mon May 2 14:15:56 2022 -0700
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/master.

ℹ Use --fixupAll option, squash the PR manually or land the PR from the command line.

https://github.com/nodejs/node/actions/runs/2260993126

Y1D7NG · 2022-05-02T23:52:15Z

need to use commit-queue-squash？

nodejs-github-bot · 2022-05-03T02:07:45Z

Landed in 2be5966

PR-URL: #42862 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs/node#42862 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

doc: fix errors in Web Streams doc

941c56e

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 25, 2022

VoltrexKeyva reviewed Apr 25, 2022

View reviewed changes

doc/api/webstreams.md Outdated Show resolved Hide resolved

doc/api/webstreams.md Outdated Show resolved Hide resolved

doc: fix typo

62203b1

Y1D7NG requested a review from VoltrexKeyva April 25, 2022 07:48

lpinca approved these changes Apr 25, 2022

View reviewed changes

VoltrexKeyva approved these changes Apr 25, 2022

View reviewed changes

Mesteery approved these changes Apr 26, 2022

View reviewed changes

HarshithaKP approved these changes Apr 26, 2022

View reviewed changes

marsonya approved these changes Apr 26, 2022

View reviewed changes

himself65 approved these changes Apr 29, 2022

View reviewed changes

Trott reviewed May 2, 2022

View reviewed changes

doc/api/webstreams.md Outdated Show resolved Hide resolved

Update doc/api/webstreams.md

440fc77

Trott reviewed May 2, 2022

View reviewed changes

doc/api/webstreams.md Outdated Show resolved Hide resolved

Update doc/api/webstreams.md

c919a8f

Trott reviewed May 2, 2022

View reviewed changes

doc/api/webstreams.md Outdated Show resolved Hide resolved

Update doc/api/webstreams.md

887ef9e

Trott approved these changes May 2, 2022

View reviewed changes

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2022

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 2, 2022

Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 2, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2022

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 2, 2022

Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 3, 2022

Trott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label May 3, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 3, 2022

nodejs-github-bot merged commit 2be5966 into nodejs:master May 3, 2022

RafaelGSS mentioned this pull request May 10, 2022

v18.2.0 proposal #43036

Merged

Y1D7NG deleted the doc-webstream branch May 18, 2022 15:49

juanarbol mentioned this pull request May 31, 2022

2022-05-XX, Version 16.16.0 'Gallium' (LTS) #43268

Closed

targos mentioned this pull request Aug 3, 2022

v16.17.0 release proposal #44098

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

doc: fix errors in Web Streams doc#42862

doc: fix errors in Web Streams doc#42862
nodejs-github-bot merged 5 commits intonodejs:masterfrom
Y1D7NG:doc-webstream

Y1D7NG commented Apr 25, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented May 2, 2022

Uh oh!

nodejs-github-bot commented May 2, 2022

Successfully rebased and updated refs/heads/master.

Uh oh!

Y1D7NG commented May 2, 2022

Uh oh!

nodejs-github-bot commented May 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

Y1D7NG commented Apr 25, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented May 2, 2022

Uh oh!

nodejs-github-bot commented May 2, 2022

Successfully rebased and updated refs/heads/master.

Uh oh!

Y1D7NG commented May 2, 2022

Uh oh!

nodejs-github-bot commented May 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants