test: simplify test-gc-{http-client,net}-* #42782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
lpinca
force-pushed
the
simplify/test-gc-xxx
branch
2 times, most recently
from
59d8f04
to
5324b0b
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
force-pushed
the
simplify/test-gc-xxx
branch
from
5324b0b
to
0d66d64
Compare
lpinca
changed the title
lpinca
force-pushed
the
simplify/test-gc-xxx
branch
from
0d66d64
to
9fd4911
Compare
lpinca
changed the title
lpinca
force-pushed
the
simplify/test-gc-xxx
branch
from
9fd4911
to
1b10c03
Compare
github-actions
bot
removed
the
request-ci
16 tasks
lpinca
force-pushed
the
simplify/test-gc-xxx
branch
from
1b10c03
to
49ba47a
Compare
jasnell
approved these changes
Apr 20, 2022
22 tasks
github-actions
bot
removed
the
request-ci
This was referenced Apr 22, 2022
21 tasks
This was referenced Apr 25, 2022
aduh95
approved these changes
Apr 28, 2022
Comment on lines
60
to
62
| } else { | ||
| setImmediate(status); | ||
| } | ||
| } else { | ||
| setImmediate(status); | ||
| } |
There was a problem hiding this comment.
nit
Suggested change
| } else { | |
| setImmediate(status); | |
| } | |
| } else { | |
| setImmediate(status); | |
| } | |
| return; | |
| } | |
| } | |
| setImmediate(status); |
There was a problem hiding this comment.
This is only a cosmetic change that is inconsistent with the original refactor done in 47ecf2060343. I would prefer to not apply it.
There was a problem hiding this comment.
Sure, feel free to ignore and land as is, LGTM anyway.
There was a problem hiding this comment.
I'll apply it, but it's a little annoying to rerun CI for something like this.
Comment on lines
68
to
69
| } else { | ||
| setImmediate(status); | ||
| } | ||
| } else { | ||
| setImmediate(status); | ||
| } |
There was a problem hiding this comment.
nit
Suggested change
| } else { | |
| setImmediate(status); | |
| } | |
| } else { | |
| setImmediate(status); | |
| } | |
| return; | |
| } | |
| } | |
| setImmediate(status); |
test/parallel/test-gc-net-timeout.js
Outdated
Comment on lines
71
to
73
| } else { | ||
| setImmediate(status); | ||
| } | ||
| } else { | ||
| setImmediate(status); | ||
| } |
There was a problem hiding this comment.
nit
Suggested change
| } else { | |
| setImmediate(status); | |
| } | |
| } else { | |
| setImmediate(status); | |
| } | |
| return; | |
| } | |
| } | |
| setImmediate(status); |
Instead of sending/creating a fixed number of requests/connections, detect when GC has started and stop sending requests/creating connections at that point. Refs: nodejs@47ecf2060343 Refs: nodejs@7ce8403ef1a6
lpinca
force-pushed
the
simplify/test-gc-xxx
branch
from
8d240e1
to
8518bd1
Compare
github-actions
bot
removed
the
request-ci
21 tasks
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/42782
✔ Done loading data for nodejs/node/pull/42782
----------------------------------- PR info ------------------------------------
Title test: simplify test-gc-{http-client,net}-* (#42782)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch lpinca:simplify/test-gc-xxx -> nodejs:master
Labels test, author ready, needs-ci
Commits 1
- test: simplify test-gc-{http-client,net}-*
Committers 1
- Luigi Pinca
PR-URL: https://github.com/nodejs/node/pull/42782
Refs: https://github.com/nodejs/node/commit/47ecf2060343
Refs: https://github.com/nodejs/node/commit/7ce8403ef1a6
Reviewed-By: James M Snell
Reviewed-By: Antoine du Hamel
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42782
Refs: https://github.com/nodejs/node/commit/47ecf2060343
Refs: https://github.com/nodejs/node/commit/7ce8403ef1a6
Reviewed-By: James M Snell
Reviewed-By: Antoine du Hamel
--------------------------------------------------------------------------------
⚠ Commits were pushed since the last review:
⚠ - test: simplify test-gc-{http-client,net}-*
ℹ This PR was created on Tue, 19 Apr 2022 13:41:44 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42782#pullrequestreview-947803586
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/42782#pullrequestreview-956901494
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2022-04-28T22:34:39Z: https://ci.nodejs.org/job/node-test-pull-request/43757/
- Querying data for job/node-test-pull-request/43757/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2247249270 |
nodejs-github-bot
added
the
commit-queue-failed
lpinca
added a commit
that referenced
this pull request
Apr 29, 2022
Instead of sending/creating a fixed number of requests/connections, detect when GC has started and stop sending requests/creating connections at that point. Refs: 47ecf2060343 Refs: 7ce8403ef1a6 PR-URL: #42782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Landed in 02e0c17. |
This was referenced Apr 30, 2022
targos
pushed a commit
that referenced
this pull request
May 2, 2022
Instead of sending/creating a fixed number of requests/connections, detect when GC has started and stop sending requests/creating connections at that point. Refs: 47ecf2060343 Refs: 7ce8403ef1a6 PR-URL: #42782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
33 tasks
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Instead of sending/creating a fixed number of requests/connections, detect when GC has started and stop sending requests/creating connections at that point. Refs: 47ecf2060343 Refs: 7ce8403ef1a6 PR-URL: #42782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
Instead of sending/creating a fixed number of requests/connections, detect when GC has started and stop sending requests/creating connections at that point. Refs: 47ecf2060343 Refs: 7ce8403ef1a6 PR-URL: #42782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Instead of sending/creating a fixed number of requests/connections, detect when GC has started and stop sending requests/creating connections at that point. Refs: 47ecf2060343 Refs: 7ce8403ef1a6 PR-URL: #42782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Instead of sending/creating a fixed number of requests/connections, detect when GC has started and stop sending requests/creating connections at that point. Refs: 47ecf2060343 Refs: 7ce8403ef1a6 PR-URL: #42782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Instead of sending/creating a fixed number of requests/connections, detect when GC has started and stop sending requests/creating connections at that point. Refs: nodejs/node@47ecf2060343 Refs: nodejs/node@7ce8403ef1a6 PR-URL: nodejs/node#42782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sending/creating a fixed number of requests/connections,
detect when GC has started and stop sending requests/creating
connections at that point.
Refs: 47ecf2060343
Refs: 7ce8403ef1a6