Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: add hasRef() to the handle object #42756

Merged
merged 1 commit into from
Apr 19, 2022
Merged

worker: add hasRef() to the handle object #42756

merged 1 commit into from
Apr 19, 2022

Conversation

RaisinTen
Copy link
Contributor

This should help projects like
https://github.com/mafintosh/why-is-node-running and
https://github.com/facebook/jest to detect if Worker instances are
keeping the event loop active correctly.

Fixes: #42091
Refs: mafintosh/why-is-node-running#59
Signed-off-by: Darshan Sen raisinten@gmail.com

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 16, 2022
This was referenced Apr 16, 2022
Closed
Closed
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTen RaisinTen added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 16, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@tniessen tniessen requested a review from addaleax April 16, 2022 16:08
@github-actions github-actions bot mentioned this pull request Apr 17, 2022
Open
15 tasks
@RaisinTen
Copy link
Contributor Author

cc @nodejs/workers

@RaisinTen
worker: add hasRef() to the handle object
abbe313 
This should help projects like
https://github.com/mafintosh/why-is-node-running and
https://github.com/facebook/jest to detect if Worker instances are
keeping the event loop active correctly.

Fixes: nodejs#42091
Refs: mafintosh/why-is-node-running#59
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen RaisinTen changed the title worker: add hasRef() worker: add hasRef() to the handle object Apr 17, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Apr 18, 2022
Open
Open
@RaisinTen
Copy link
Contributor Author

cc @addaleax

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 19, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43565/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2022
@aduh95
Copy link
Contributor

aduh95 commented Apr 19, 2022

Should this be labelled semver-minor PRs that contain new features and should be released in the next minor version. ?

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit 1b8d179 into nodejs:master Apr 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 1b8d179

@github-actions github-actions bot mentioned this pull request Apr 20, 2022
Open
16 tasks
@RaisinTen RaisinTen deleted the worker/add-hasRef branch April 20, 2022 14:50
@RaisinTen RaisinTen added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 20, 2022
This was referenced Apr 21, 2022
Open
Open
RaisinTen added a commit to RaisinTen/why-is-node-running that referenced this pull request Apr 24, 2022
@RaisinTen
Correctly detect unref'ed handles
4e1788d 
At this point, Timeout objects aren't the only handles that have a
hasRef() method. nodejs/node#42756 added
hasRef() to the Worker handle object that gets reported by async_hooks,
so we should consider that too.

Fixes: mafintosh#59
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen RaisinTen mentioned this pull request Apr 24, 2022
Merged
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@RaisinTen @xtx1130
worker: add hasRef() to the handle object
2e16a4e 
This should help projects like
https://github.com/mafintosh/why-is-node-running and
https://github.com/facebook/jest to detect if Worker instances are
keeping the event loop active correctly.

Fixes: nodejs#42091
Refs: mafintosh/why-is-node-running#59
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs#42756
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
mafintosh pushed a commit to mafintosh/why-is-node-running that referenced this pull request Apr 26, 2022
@RaisinTen @mafintosh
Correctly detect unref'ed handles
48c2e21 
At this point, Timeout objects aren't the only handles that have a
hasRef() method. nodejs/node#42756 added
hasRef() to the Worker handle object that gets reported by async_hooks,
so we should consider that too.

Fixes: #59
Signed-off-by: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2022
@RaisinTen @targos
worker: add hasRef() to the handle object
c3922af 
This should help projects like
https://github.com/mafintosh/why-is-node-running and
https://github.com/facebook/jest to detect if Worker instances are
keeping the event loop active correctly.

Fixes: #42091
Refs: mafintosh/why-is-node-running#59
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42756
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos
Copy link
Member

targos commented May 2, 2022

Should this be labelled semver-minor ?

I don't think so. The handle object isn't public API.

@targos targos removed the semver-minor PRs that contain new features and should be released in the next minor version. label May 2, 2022
@targos targos mentioned this pull request May 2, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@RaisinTen @juanarbol
worker: add hasRef() to the handle object
2fe8a79 
This should help projects like
https://github.com/mafintosh/why-is-node-running and
https://github.com/facebook/jest to detect if Worker instances are
keeping the event loop active correctly.

Fixes: #42091
Refs: mafintosh/why-is-node-running#59
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42756
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@RaisinTen @danielleadams
worker: add hasRef() to the handle object
51a0fd1 
This should help projects like
https://github.com/mafintosh/why-is-node-running and
https://github.com/facebook/jest to detect if Worker instances are
keeping the event loop active correctly.

Fixes: #42091
Refs: mafintosh/why-is-node-running#59
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42756
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@RaisinTen @targos
worker: add hasRef() to the handle object
1f761a4 
This should help projects like
https://github.com/mafintosh/why-is-node-running and
https://github.com/facebook/jest to detect if Worker instances are
keeping the event loop active correctly.

Fixes: #42091
Refs: mafintosh/why-is-node-running#59
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42756
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@RaisinTen @targos
worker: add hasRef() to the handle object
293bab7 
This should help projects like
https://github.com/mafintosh/why-is-node-running and
https://github.com/facebook/jest to detect if Worker instances are
keeping the event loop active correctly.

Fixes: #42091
Refs: mafintosh/why-is-node-running#59
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42756
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@RaisinTen @guangwong
worker: add hasRef() to the handle object
952e0e2 
This should help projects like
https://github.com/mafintosh/why-is-node-running and
https://github.com/facebook/jest to detect if Worker instances are
keeping the event loop active correctly.

Fixes: nodejs/node#42091
Refs: mafintosh/why-is-node-running#59
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs/node#42756
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@mjameswh mjameswh mentioned this pull request Nov 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hasRef to worker_threads.Worker
5 participants
@RaisinTen @nodejs-github-bot @aduh95 @targos @addaleax