doc: add maintaining info for shared library option#42517
Closed
mhdawson wants to merge 26 commits intonodejs:masterfrom
Closed
doc: add maintaining info for shared library option#42517mhdawson wants to merge 26 commits intonodejs:masterfrom
mhdawson wants to merge 26 commits intonodejs:masterfrom
Conversation
Refs: nodejs#41850 I think it would be good to have some info/context for maintainers on the shared library option. Add that based on disussion in nodejs#41850 Signed-off-by: Michael Dawson <mdawson@devrus.com>
Collaborator
|
Review requested:
|
mscdex
reviewed
Mar 29, 2022
mscdex
reviewed
Mar 29, 2022
mscdex
reviewed
Mar 29, 2022
mscdex
reviewed
Mar 29, 2022
mscdex
changed the title
mscdex
reviewed
Mar 29, 2022
mscdex
reviewed
Mar 29, 2022
mscdex
reviewed
Mar 29, 2022
mscdex
reviewed
Mar 29, 2022
mscdex
reviewed
Mar 29, 2022
mscdex
reviewed
Mar 29, 2022
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Member
Author
|
@mscdex thanks for the review, can't believe I spelled library wrong so many times. |
Co-authored-by: Tierney Cyren <accounts@bnb.im>
Co-authored-by: Tierney Cyren <accounts@bnb.im>
Member
Author
|
@bnb comments addressed. |
lux01
reviewed
Apr 21, 2022
Comment on lines
52
to
61
| For the node.exe wrapper, it is built so that it can | ||
| find the shared library in one of the following: | ||
|
|
||
| * the same directory as the node executable | ||
| * ../lib with the expectation that the executable is | ||
| installed in a `bin` directory at the same level | ||
| as a `lib` directory in which the shared library is | ||
| installed. This is where the default package that | ||
| is build with the shared library option will | ||
| place the executable and library. |
Contributor
There was a problem hiding this comment.
I think this is only true on Linux and macOS where we can embed a relative RPATH into the executable. AIX doesn't have this luxury so currently it hard codes an absolute path to libnode.a into the executable.
On Windows libnode.dll and node.exe sit in the same directory as this is the expected location for DLLs. See this MSDN article if you want to know more about the DLL search order on Windows.
Member
Author
There was a problem hiding this comment.
@lux01 updated, can you tell me what the hardcoded path for AIX is so that I can add it?
mhdawson
commented
Apr 21, 2022
mhdawson
commented
Apr 21, 2022
mhdawson
commented
Apr 21, 2022
Member
Author
|
@lux01 I think this now reflects the current implementation in terms of what was landed. Can you take one more look before I land it? |
Signed-off-by: Michael Dawson <mdawson@devrus.com>
Member
Author
|
I'm going to go ahead and land and I'll update if there are any follow on comments. |
mhdawson
added a commit
that referenced
this pull request
May 12, 2022
Refs: #41850 I think it would be good to have some info/context for maintainers on the shared library option. Add that based on disussion in #41850 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42517 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Member
Author
|
Landed in 8b415e8 |
BethGriggs
pushed a commit
that referenced
this pull request
May 16, 2022
Refs: #41850 I think it would be good to have some info/context for maintainers on the shared library option. Add that based on disussion in #41850 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42517 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Refs: #41850 I think it would be good to have some info/context for maintainers on the shared library option. Add that based on disussion in #41850 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42517 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
Refs: #41850 I think it would be good to have some info/context for maintainers on the shared library option. Add that based on disussion in #41850 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42517 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Refs: #41850 I think it would be good to have some info/context for maintainers on the shared library option. Add that based on disussion in #41850 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42517 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Refs: #41850 I think it would be good to have some info/context for maintainers on the shared library option. Add that based on disussion in #41850 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42517 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Refs: nodejs/node#41850 I think it would be good to have some info/context for maintainers on the shared library option. Add that based on disussion in nodejs/node#41850 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node#42517 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #41850
I think it would be good to have some info/context
for maintainers on the shared library option. Add that
based on disussion in #41850
Signed-off-by: Michael Dawson mdawson@devrus.com