Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixing broken links to the v8 wiki #4241

Closed
wants to merge 1 commit into from

Conversation

tomgco
Copy link
Contributor

@tomgco tomgco commented Dec 11, 2015

The docs and _debugger.js are currently linking to the now non-existing v8 wiki on the v8 issue tracker; Instead it has now been moved to https://github.com/v8/v8/wiki

@evanlucas
Copy link
Contributor

LGTM

@mscdex mscdex added doc Issues and PRs related to the documentations. debugger v8 engine Issues and PRs related to the V8 dependency. labels Dec 11, 2015
@bnoordhuis
Copy link
Member

LGTM

@JungMinu
Copy link
Member

minor nit : docs -> doc

@JungMinu JungMinu self-assigned this Dec 11, 2015
@JungMinu
Copy link
Member

LGTM with one small comment :)

@tomgco
Copy link
Contributor Author

tomgco commented Dec 11, 2015

LGTM with one small comment :)

Thanks! Fixed up that.

jasnell pushed a commit that referenced this pull request Dec 11, 2015
PR-URL: #4241
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 11, 2015

Landed in 9a9c525

@jasnell jasnell closed this Dec 11, 2015
cjihrig pushed a commit that referenced this pull request Dec 15, 2015
PR-URL: #4241
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@rvagg rvagg mentioned this pull request Dec 17, 2015
MylesBorins pushed a commit that referenced this pull request Dec 30, 2015
PR-URL: #4241
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
PR-URL: #4241
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4241
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants