test: use void to indicate "useless" expressions#41929
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: use void to indicate "useless" expressions#41929Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
needs-ci
Instead of disabling the `no-unused-expressions` ESLint rule, mark intentional "useless" expressions with `void`. Refs: https://eslint.org/docs/rules/no-unused-expressions#options
github-actions
bot
removed
the
request-ci
Collaborator
aduh95
approved these changes
Feb 11, 2022
Member
|
The |
benjamingr
reviewed
Feb 11, 2022
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
(I don't think this improves code quality and I think it introduces a pretty rarely used language feature to help with an eslint rule)
Member
Author
I think you're right. I want to believe there's something more semantic about |
19 tasks
jasnell
approved these changes
Feb 12, 2022
19 tasks
This was referenced Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of disabling the
no-unused-expressionsESLint rule, markintentional "useless" expressions with
void.Refs: https://eslint.org/docs/rules/no-unused-expressions#options