util: make debuglog show up in --inspect logs

[bmeck]

This makes util.debuglog() show up in the inspector console under the debug level.

@joyeecheung I've removed the TODO comment since it loses data prior to connection of an inspector which is a UX degradation from the existing situation and doesn't match other environments for JS.

This does cause the same kind of memory leak while retaining messages as console currently does but it only does so if the specific debuglog set is enabled.

[nodejs-github-bot]

Review requested:

• @nodejs/startup

[joyeecheung]

Removing the TODO LGTM (it already doesn't matter now that we snapshot the console methods) , but I have a question regarding the implementation of the wrapping

[bmeck]

To fix some tests I had to make colors work, this causes some dependency on #32308 in a way. I think I addressed the concern in that PR though by injecting the color setting via DI rather than doing it in all Console objects.

CC: @addaleax @BridgeAR

[bmeck]

@addaleax I've pulled out the console changes for now. Would it be fine to have these as a separate PR still?

[addaleax]

Would it be fine to have these as a separate PR still?

I think so -- it's definitely a breaking change, though. (This PR doesn't need to be semver-major anymore imo.)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/43121/

[antsmartian]

@bmeck Ping. Are we planning to get this to a closure?

[aduh95]

This needs a rebase.

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

[github-actions]

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.