src: gracefully handle errors in GetX509NameObject #41490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anna Henningsen <anna@addaleax.net>
|
Review requested:
|
nodejs-github-bot
added
c++
addaleax
approved these changes
Jan 12, 2022
cjihrig
approved these changes
Jan 12, 2022
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This was referenced Jan 13, 2022
VoltrexKeyva
added
author ready
tniessen
added a commit
that referenced
this pull request
Jan 14, 2022
Co-authored-by: Anna Henningsen <anna@addaleax.net> PR-URL: #41490 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 4dd1f42, thanks for reviewing. |
tniessen
added a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #41490 Co-authored-by: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #41490 Co-authored-by: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
26 tasks
tniessen
deleted the
src-gracefully-handle-errors-in-getx509nameobject
branch
mawaregetsuka
pushed a commit
to mawaregetsuka/node
that referenced
this pull request
Jan 17, 2022
PR-URL: nodejs#41490 Co-authored-by: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
thedull
pushed a commit
to thedull/node
that referenced
this pull request
Jan 18, 2022
PR-URL: nodejs#41490 Co-authored-by: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41490 Co-authored-by: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #41490 Co-authored-by: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When V8 reports an exception, fail gracefully instead of terminating the process in
GetX509NameObject.A huge thanks to @addaleax for pointing this out.
While this function was added as part of a security release (a336444), this patch does not affect security. Exceptions can realistically only occur due to custom setters on the
Arrayprototype.