doc: fix example in node-api docs #41264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: nodejs#39564 Signed-off-by: Michael Dawson <mdawson@devrus.com>
|
Review requested:
|
nodejs-github-bot
added
doc
cjihrig
approved these changes
Dec 21, 2021
tniessen
approved these changes
Dec 21, 2021
lpinca
approved these changes
Dec 21, 2021
jasnell
approved these changes
Dec 21, 2021
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
cc @nodejs/node-api FWIW I've opened a PR to fix the team name: #41268 |
NickNaso
approved these changes
Dec 21, 2021
legendecas
approved these changes
Dec 22, 2021
HarshithaKP
approved these changes
Dec 22, 2021
|
Landed in 6ce085c |
mhdawson
added a commit
that referenced
this pull request
Dec 23, 2021
Fixes: #39564 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41264 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
Fixes: #39564 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41264 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Fixes: #39564 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41264 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Fixes: nodejs#39564 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#41264 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Fixes: #39564 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41264 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #39564
Signed-off-by: Michael Dawson mdawson@devrus.com