Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loader: fix package resolution for edge case #41218

Merged
merged 14 commits into from
Dec 22, 2021
Merged

loader: fix package resolution for edge case #41218

merged 14 commits into from
Dec 22, 2021

Commits on Dec 17, 2021

  1. loader: fix package resolution for edge case 

    this commit solves a regression introduced with PR-40980.
if a resolve call results in a script with .mjs extension the
is automatically set to . This avoids the case where an additional
 in the same directory as the .mjs file would declare the
 to commonjs
    @dygabo
    dygabo committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    a149086 View commit details
    Browse the repository at this point in the history

  2. fixup! loader: fix package resolution for edge case

    @dygabo
    dygabo committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    db7a12a View commit details
    Browse the repository at this point in the history

  3. rewrite based on review comments and defaultGetFormat implementation

    @dygabo
    dygabo committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    6f7d871 View commit details
    Browse the repository at this point in the history

  4. review comments, rework tests

    @dygabo
    dygabo committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    435dc9b View commit details
    Browse the repository at this point in the history

  5. review comments, test cases added for query and hash export urls

    @dygabo
    dygabo committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    f9fe067 View commit details
    Browse the repository at this point in the history

  6. review round

    @dygabo
    dygabo committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    0bb04f2 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2021

  1. refactoring amendFormatToUrl out in moduleResolve + other review comm… 

    …ents
    @dygabo
    dygabo committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    a72ad73 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2021

  1. refactor to getPackageFormat

    @dygabo
    dygabo committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    05d7f87 View commit details
    Browse the repository at this point in the history

  2. next review round

    @dygabo
    dygabo committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    16f422f View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. review findings

    @dygabo
    dygabo committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    a4c3456 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. amendFormatToUrl also if resolve by relative path to module

    @dygabo
    dygabo committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    9a45c2b View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. fixup: refactoring 

    Signed-off-by: Gabriel Bota <gabriel.bota@dynatrace.com>
    @guybedford @dygabo
    guybedford authored and dygabo committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    8b741f0 View commit details
    Browse the repository at this point in the history

  2. fixup: linter errors

    @dygabo
    dygabo committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    01a3abc View commit details
    Browse the repository at this point in the history

  3. fixup: review findings

    @dygabo
    dygabo committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    fdf0d4d View commit details
    Browse the repository at this point in the history