tools,lib: enable jsdoc/require-returns-type ESLint rule - #41130
Closed
Trott wants to merge 2 commits into
Closed
Conversation
Add types to @returns JSDoc annotations where the type is missing.
Trott
added
the
commit-queue-rebase
nodejs-github-bot
added
lib / src
Member
|
s/reutrns/returns/ |
targos
approved these changes
Dec 10, 2021
Trott
force-pushed
the
require-returns-type
branch
from
December 10, 2021 13:00
2d21012 to
0ae51d3
Compare
Trott
changed the title
github-actions
Bot
removed
the
request-ci
Collaborator
jasnell
approved these changes
Dec 10, 2021
lpinca
approved these changes
Dec 10, 2021
47 tasks
Collaborator
Trott
added
the
author ready
BridgeAR
approved these changes
Dec 11, 2021
48 tasks
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in c2ff69d...12e3c74 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2021
PR-URL: #41130 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
46 tasks
46 tasks
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
PR-URL: #41130 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Dec 15, 2021
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #41130 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Feb 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.