Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch V8 to 9.6.180.15 #40949

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Conversation

targos
Copy link
Member

@targos targos commented Nov 24, 2021

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Nov 24, 2021
@targos targos added dont-land-on-v12.x and removed v8 engine Issues and PRs related to the V8 dependency. needs-ci PRs that need a full CI run. labels Nov 24, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 24, 2021

@richardlau
Copy link
Member

Refs: v8/v8@9.6.180.14...9.6.180.15

This one's a dead link... I'm guessing V8 no longer mirror 9.6 updates to GitHub anymore?

@targos
Copy link
Member Author

targos commented Nov 24, 2021

It's an issue with Github. See https://bugs.chromium.org/p/v8/issues/detail?id=12340

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 29, 2021
@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2021
@nodejs-github-bot nodejs-github-bot merged commit 648c5cb into nodejs:master Nov 29, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 648c5cb

@targos targos deleted the v8-9.6.180.15 branch November 29, 2021 14:57
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
Refs: v8/v8@9.6.180.14...9.6.180.15

PR-URL: #40949
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
Refs: v8/v8@9.6.180.14...9.6.180.15

PR-URL: #40949
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants