Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: drain Transform with 0 highWaterMark #40947

Closed
wants to merge 2 commits into from
Closed

stream: drain Transform with 0 highWaterMark #40947

wants to merge 2 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Nov 24, 2021 •
edited
Loading

Fixes: #40935

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 24, 2021
@ronag ronag changed the title Transform hwm 0 stream: drain Transform with 0 highWaterMark Nov 24, 2021
@ronag ronag requested a review from mcollina November 24, 2021 08:43
@ronag ronag added lts-watch-v16.x stream Issues and PRs related to the stream subsystem. and removed meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 24, 2021
mcollina
mcollina approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag
Copy link
Member Author

ronag commented Nov 24, 2021

@nodejs/streams

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
lpinca
lpinca approved these changes Nov 24, 2021
View reviewed changes
test/parallel/test-stream-passthrough-drain.js Outdated Show resolved Hide resolved
@ronag @lpinca
Update test/parallel/test-stream-passthrough-drain.js
f88c666 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 24, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Nov 25, 2021
Open
38 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Nov 26, 2021
Open
33 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Nov 27, 2021
Open
27 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41153/

@ronag
Copy link
Member Author

ronag commented Nov 27, 2021

Landed in 37f1dd9

@ronag ronag closed this Nov 27, 2021
ronag added a commit that referenced this pull request Nov 27, 2021
@ronag
stream: drain Transform with 0 highWaterMark
37f1dd9 
Fixes: #40935

PR-URL: #40947
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Nov 28, 2021
Open
Open
targos pushed a commit that referenced this pull request Nov 29, 2021
@ronag @targos
stream: drain Transform with 0 highWaterMark
86d1c0b 
Fixes: #40935

PR-URL: #40947
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Nov 29, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@ronag @danielleadams
stream: drain Transform with 0 highWaterMark
ea8a455 
Fixes: #40935

PR-URL: #40947
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@ronag @danielleadams
stream: drain Transform with 0 highWaterMark
3b1c012 
Fixes: #40935

PR-URL: #40947
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
@paulrutter paulrutter mentioned this pull request Mar 25, 2022
Open
@kanongil
Copy link
Contributor

This fix is faulty and causes a regression in my stream code, which can no longer use the highWaterMark: 0 option. This issue is still present in the latest releases, including v18! #42457 seems to detail the issue. Essentially this "fix" removes all backpressure.

I explicitly test against this here, since my transform stream relies on it working.

I guess I will have to continue running node 14 on my servers.

@benjamingr
Copy link
Member

@kanongil can you please open a new separate issue (pointing to this PR) and I'll ping stream maintainers?

@kanongil
Copy link
Contributor

@benjamingr It's already described in #42457, which I have amended with my info.

kanongil added a commit to kanongil/node-1 that referenced this pull request Jul 1, 2022
@kanongil
stream: fix Transform with hwm 0 regression
6c98049 
Fixes: nodejs#40935
Refs: nodejs#40947
Refs: nodejs#42457
@kanongil kanongil mentioned this pull request Jul 1, 2022
Closed
kanongil added a commit to kanongil/node-1 that referenced this pull request Jul 1, 2022
@kanongil
stream: fix Transform with hwm 0 regression
b8a1698 
Fixes: nodejs#40935
Refs: nodejs#40947
Refs: nodejs#42457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stream.PassThrough not draining (from Node 16)
8 participants
@ronag @nodejs-github-bot @kanongil @benjamingr @mcollina @lpinca @tniessen @targos