Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,crypto: use ByteSource::ToBuffer() in crypto_dh #40903

Merged
merged 1 commit into from
Nov 25, 2021
Merged

src,crypto: use ByteSource::ToBuffer() in crypto_dh #40903

merged 1 commit into from
Nov 25, 2021

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen darshan.sen@postman.com

@RaisinTen
src,crypto: use ByteSource::ToBuffer() in crypto_dh
037e52b 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Nov 21, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41023/

@github-actions github-actions bot mentioned this pull request Nov 22, 2021
Open
40 tasks
@github-actions github-actions bot mentioned this pull request Nov 23, 2021
Open
45 tasks
@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 23, 2021
This was referenced Nov 24, 2021
Open
Open
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2021
@nodejs-github-bot nodejs-github-bot merged commit 50f3428 into nodejs:master Nov 25, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 50f3428

@RaisinTen RaisinTen deleted the use-ByteSource-ToBuffer-in-crypto_dh branch November 25, 2021 04:45
@github-actions github-actions bot mentioned this pull request Nov 26, 2021
Open
33 tasks
targos pushed a commit that referenced this pull request Nov 26, 2021
@RaisinTen @targos
src,crypto: use ByteSource::ToBuffer() in crypto_dh
acbd822 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40903
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@RaisinTen @danielleadams
src,crypto: use ByteSource::ToBuffer() in crypto_dh
d420f34 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40903
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@RaisinTen @danielleadams
src,crypto: use ByteSource::ToBuffer() in crypto_dh
807536c 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40903
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RaisinTen @nodejs-github-bot @addaleax @tniessen @aduh95