src,crypto: remove uses of AllocatedBuffer from crypto_sig
#40895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
nodejs-github-bot
added
c++
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Nov 20, 2021
41 tasks
RaisinTen
added
author ready
This was referenced Nov 22, 2021
RaisinTen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/40895 ✔ Done loading data for nodejs/node/pull/40895 ----------------------------------- PR info ------------------------------------ Title src,crypto: remove uses of `AllocatedBuffer` from `crypto_sig` (#40895) Author Darshan Sen (@RaisinTen) Branch RaisinTen:src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_sig -> nodejs:master Labels crypto, c++, author ready Commits 1 - src,crypto: remove uses of `AllocatedBuffer` from `crypto_sig` Committers 1 - Darshan Sen PR-URL: https://github.com/nodejs/node/pull/40895 Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40895 Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 20 Nov 2021 14:52:50 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40895#pullrequestreview-811856756 ✖ This PR needs to wait 5 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-11-21T05:00:27Z: https://ci.nodejs.org/job/node-test-pull-request/41019/ - Querying data for job/node-test-pull-request/41019/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1510147352 |
nodejs-github-bot
added
the
commit-queue-failed
RaisinTen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 90faf55 |
RaisinTen
deleted the
src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_sig
branch
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40895 Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40895 Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40895 Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40895 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan Sen darshan.sen@postman.com