v17.1.0 release proposal #40758
Merged
v17.1.0 release proposal #40758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #40490 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
PR-URL: #40433 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
PR-URL: #40433 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
The request uses chunked transfer encoding and the HTTP response status code is not 400 but 200. PR-URL: #40486 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #40517 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: nodejs/TSC#1096 PR-URL: #40523 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Add a section to the Major Releases section of the release guide to cover updating the list of expected files for the promotion tool. PR-URL: #40470 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
This merges the `IsEmpty()` call and the `ToLocalChecked()` call into a single `ToLocal()` call. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40386 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40400 Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #40409 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
There is no need to crash the process if any of these checks fail. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40425 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fix up example and make it more explicit on how you need to use napi_extended_error_info in order to help people avoid what might be a common mistake that we made in node-addon-api. Refs: nodejs/node-addon-api#1089 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40458 Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Currently using the --openssl-is-fips configuration option in combination with --ninja is broken. This commit fixes two issues, one being an issue with the linker/version script path variable. The second is that the locations of built artifacts that differ for ninja and make. ninja: $ ./configure --openssl-is-fips --ninja $ ninja -C out/Release $ ./node --enable-fips -p 'crypto.getFips()' 1 make: $ ./configure --openssl-is-fips $ make -j8 $ ./node --enable-fips -p 'crypto.getFips()' 1 PR-URL: #40518 Refs: #40509 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
PR-URL: #40464 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Yihong Wang <yh.wang@ibm.com>
PR-URL: #40539 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #40473 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40457 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Document the things that are considered when making the determination as to whether something should or shouldn't be in core. This does not (yet, at least) attempt to address *how* to include modules in core. (Should it be in the Node.js code base or vendored in from a separate repository?) It is limited to *whether* something should be in core or not. Closes: nodejs/TSC#1041 PR-URL: #40338 Fixes: nodejs/TSC#1041 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #40527 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #40563 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
PR-URL: #40520 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: #39759 (comment) PR-URL: #40531 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Update documentation to match the changed `--dns-result-order` default value in Node.js 17. Refs: #39987 PR-URL: #40538 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
removed
meta
23 tasks
9 tasks
|
@nodejs/releasers |
tniessen
approved these changes
Nov 9, 2021
This change constitute a breaking change for folks who were using |
|
The changelog is the right place to write this, but the release is already built and ready to be promoted. Please tell me within the next hour if you're going to suggest changes. |
@aduh95 what is the breaking change if I may ask? |
BethGriggs
approved these changes
Nov 9, 2021
targos
added a commit
that referenced
this pull request
Nov 9, 2021
Notable changes: doc: * add VoltrexMaster to collaborators (voltrexmaster) #40566 esm: * (SEMVER-MINOR) add support for JSON import assertion (Antoine du Hamel) #40250 lib: * (SEMVER-MINOR) add unsubscribe method to non-active DC channels (simon-id) #40433 * (SEMVER-MINOR) add return value for DC channel.unsubscribe (simon-id) #40433 v8: * (SEMVER-MINOR) multi-tenant promise hook api (Stephen Belanger) #39283 PR-URL: #40758
The import assertion is now required to import JSON modules. This used to work with Node.js 17.0.1 when run with import info from './package.json';Now you need to do this: import info from './package.json' assert { type: 'json' };If you need support for assertionless JSON modules import, you need to implement a custom loader hook such as: const DATA_URL_PATTERN = /^data:application\/json(?:[^,]*?)(;base64)?,([\s\S]*)$/;
const JSON_URL_PATTERN = /\.json(\?[^#]*)?(#.*)?$/;
export function load(url, context, next) {
if (context.importAssertions.type == null &&
(DATA_URL_PATTERN.test(url) || JSON_URL_PATTERN.test(url))) {
const { importAssertions } = context;
importAssertions.type = 'json';
}
return next(url, context);
}
Clearly I missed the window, please ignore, I'll make sure to have something ready when we will backport this change to v16 LTS. |
targos
added a commit
to targos/nodejs.org
that referenced
this pull request
Nov 9, 2021
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 9, 2021
26 tasks
This was referenced Nov 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-11-09, Version 17.1.0 (Current), @targos
Notable Changes
89b34ecffb] - doc: add VoltrexMaster to collaborators (voltrexmaster) #4056695e4d29eb4] - (SEMVER-MINOR) esm: add support for JSON import assertion (Antoine du Hamel, Geoffrey Booth) #402501ddbae2d76] - (SEMVER-MINOR) lib: add unsubscribe method to non-active DC channels (simon-id) #40433aa61551b49] - (SEMVER-MINOR) lib: add return value for DC channel.unsubscribe (simon-id) #40433fbeb895ca6] - (SEMVER-MINOR) v8: multi-tenant promise hook api (Stephen Belanger) #39283Commits
8a00dc5add] - build: skip long-running Actions for README-only modifications (Rich Trott) #405719f46fca124] - build: disable v8 pointer compression on 32bit archs (Cheng Zhao) #404185bef74395d] - deps: patch V8 to 9.5.172.25 (Michaël Zasso) #406043805b806ee] - deps: upgrade npm to 8.1.2 (npm team) #40643c003ba131b] - deps: update c-ares to 1.18.1 (Richard Lau) #40660841f35cc52] - deps: upgrade npm to 8.1.1 (npm team) #405548d16f0d2d3] - deps: V8: cherry-pick 422dc378a1da (Ray Wang) #40450cdf5c44d62] - deps: add riscv64 config into openssl gypi (Lu Yahan) #404732b9fcdfe26] - deps: attempt to suppress macro-redefined warning (Daniel Bevenius) #40518d2839bfaa9] - deps: regenerate OpenSSL arch files (Daniel Bevenius) #405185df8ce5cbe] - deps,build,tools: fix openssl-is-fips for ninja builds (Daniel Bevenius) #4051879bf429405] - dgram: fix send with out of bounds offset + length (Nitzan Uziely) #40568c29658fda7] - doc: update cjs-module-lexer repo link (Guy Bedford) #40707e374f3ddd9] - doc: fix lint re-enabling comment in README.md (Rich Trott) #40647ecccf48106] - doc: format v8.md in preparation for stricter linting (Rich Trott) #4064795a7117037] - doc: final round of markdown format changes (Rich Trott) #40645c104f5a9ab] - doc: remove--experimental-modulesdocumentation (FrankQiu) #38974ac81f89bbf] - doc: update tracking issues of startup performance (Joyee Cheung) #4062965effa11fc] - doc: fix markdown syntax and HTML tag misses (ryan) #40608c78d708a16] - doc: use ‘GitHub Actions workflow’ instead (Mestery) #4058671bac70bf2] - doc: ref OpenSSL legacy provider from crypto docs (Tobias Nießen) #405938f410229ac] - doc: add node: url scheme (Daniel Nalborczyk) #4057335dbed21f2] - doc: call cwd function (Daniel Nalborczyk) #405734870a23ccc] - doc: remove unused imports (Daniel Nalborczyk) #405735951ccc12e] - doc: simplify CHANGELOG.md (Rich Trott) #404756ae134ecb7] - doc: correct esm spec scope lookup definition (Guy Bedford) #4059209239216f6] - doc: update CHANGELOG.md for Node.js 16.13.0 (Richard Lau) #4061746ec5ac4df] - doc: add info on project’s usage of coverity (Michael Dawson) #405067eb1a44410] - doc: fix typo in changelogs (Luigi Pinca) #40585132f6cba05] - doc: update onboarding task (Rich Trott) #405705e2d0ed61e] - doc: simplify ccache instructions (Rich Trott) #40550c1c1738bfc] - doc: fix macOS environment variables for ccache (Rich Trott) #405506e3e50f2ab] - doc: improve async_context introduction (Michaël Zasso) #405601587fe62d4] - doc: use GFM footnotes in webcrypto.md (Rich Trott) #40477305c022db4] - doc: describe buffer limit of v8.serialize (Ray Wang) #402436e39e0e10a] - doc: run license-builder (Rich Trott) #40540556e49ccb5] - doc: use GFM footnotes in maintaining-V8.md (doc: use GFM footnotes in maintaining-V8.md #40476) (Rich Trott) #404769c6a9fd5b1] - doc: use GFM footnotes in BUILDING.md (Rich Trott) #40474fd946215cc] - doc: fixfs.symlinkcode example (Juan José Arboleda) #40414404730ac1b] - doc: update for changed--dns-result-orderdefault (Richard Lau) #40538acc22c7c4a] - doc: add missing entry inglobals.md(Antoine du Hamel) #405310375d958ef] - doc: explain backport labels (Stephen Belanger) #405204993d87c49] - doc: fix entry for Slack channel in onboarding.md (Rich Trott) #4056389b34ecffb] - doc: add VoltrexMaster to collaborators (voltrexmaster) #405666357ef15d0] - doc: document considerations for inclusion in core (Rich Trott) #40338ed04827373] - doc: update link in onboarding doc (Rich Trott) #4053934e244b8e9] - doc: clarify behavior of napi_extended_error_info (Michael Dawson) #404585a588ff047] - doc: add updating expected assets to release guide (Richard Lau) #4047095e4d29eb4] - (SEMVER-MINOR) esm: add support for JSON import assertion (Antoine du Hamel) #40250825a683423] - http: response should always emit ‘close’ (Robert Nagy) #4054381cd7f3751] - lib: fix regular expression to detect `/` and `\` (Francesco Trotta) #403251ddbae2d76] - (SEMVER-MINOR) lib: add unsubscribe method to non-active DC channels (simon-id) #40433aa61551b49] - (SEMVER-MINOR) lib: add return value for DC channel.unsubscribe (simon-id) #40433d97872dd98] - meta: use form schema for flaky test template (Michaël Zasso) #40737c2fabdbce8] - meta: update AUTHORS (Node.js GitHub Bot) #40668aa98c6bdce] - meta: consolidate AUTHORS entries for brettkiefer (Rich Trott) #4059918296c3d8e] - meta: consolidate AUTHORS entries for alexzherdev (Rich Trott) #4062088d812793d] - meta: consolidate AUTHORS entries for Azard (Rich Trott) #40619d81b65ca0e] - meta: move Fishrock123 to emeritus (Jeremiah Senkpiel) #40596ec02e7b68a] - meta: consolidate AUTHORS entries for clakech (Rich Trott) #4058908e7a2ff24] - meta: consolidate AUTHORS entries for darai0512 (Rich Trott) #40569488ee51f90] - meta: update AUTHORS (Node.js GitHub Bot) #40580ba9a6c5d06] - meta: consolidate AUTHORS entries for dfabulich (Rich Trott) #40527bd06e9945e] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #404647cee125dcf] - meta: add Richard Lau to TSC list in README.md (Rich Trott) #405236a771f8bcb] - meta: consolidate AUTHORS entries for dguo (Rich Trott) #40517e4c740646d] - meta: consolidate AUTHORS entries for cxreg (Rich Trott) #40490075cfbf941] - module: resolver & spec hardening /w refactoring (Guy Bedford) #40510b320387c83] - policy: fix message for invalid manifest specifier (Rich Trott) #40574ea968d54c5] - process: refactor execution (Voltrex) #40664fb7c437b0b] - src: make LoadEnvironment with string work with builtin modules path (Michaël Zasso) #40607e9388c87bf] - src: remove usage ofAllocatedBufferfromnode_http2(Darshan Sen) #405847a22f913b0] - src: fix #endif description in crypto_keygen.h (Tobias Nießen) #40639396342e26d] - src: throw error instead of assertion (Ray Wang) #40243accab383a1] - src: register external references in os bindings (Joyee Cheung) #40239a11f9ea4f0] - src: register external references in crypto bindings (Joyee Cheung) #40239ef1ace7e88] - src,crypto: usestd::variantin DH params (Darshan Sen) #404574433852f62] - src,crypto: removeAllocatedBufferfromcrypto_cipher.cc(Darshan Sen) #40400814126c3ed] - src,fs: removeToLocalChecked()call fromfs::AfterMkdirp()(Darshan Sen) #40386d4b45cc249] - src,stream: remove*Check*()calls from non-Initialize()functions (Darshan Sen) #40425bac7fe0797] - stream: remove no longer necessary ComposeDuplex (Robert Nagy) #40545e58cce49fd] - test: disable warnings to fix flaky test (Antoine du Hamel) #407398c103ab2ff] - test: skip macos sandbox test with builtin modules path (Michaël Zasso) #40607ac3bc6eed0] - test: add semicolon after chunk size (Luigi Pinca) #4048795fe9bb922] - test: deflake http2-cancel-while-client-reading (Luigi Pinca) #40659dfd0215266] - test: avoid deep comparisons with literals (Tobias Nießen) #406345020f634b8] - test: mark test-policy-integrity flaky on Windows (Rich Trott) #406848fa1c61e40] - test: fix test-datetime-change-notify after daylight change (Piotr Rybak) #40684179a5c5436] - test: testcrypto.setEngine()using an actual engine (Darshan Sen) #40481cf6ded4db5] - test: use conventional argument order in assertion (Tobias Nießen) #40591aefb097d6a] - test: fix test description (Luigi Pinca) #40486126e669b84] - test,doc: correct documentation for runBenchmark() (Rich Trott) #406831844463ce2] - test,tools: increase pummel/benchmark test timeout from 4x to 6x (Rich Trott) #40684f731f5ffb5] - test,tools: increase timeout for benchmark tests (Rich Trott) #40684bbc10f1849] - tools: simplify and fix commit queue (Michaël Zasso) #40742a3df50d810] - tools: ensure the PR was not pushed before merging (Antoine du Hamel) #40747306d953c15] - tools: update ESLint to 8.2.0 (Luigi Pinca) #40734b7e736843c] - tools: use GitHub Squash and Merge feature when using CQ (Antoine du Hamel) #4066650d102ec08] - tools: fix bug inprefer-primordialsESLint rule (Antoine du Hamel) #40628ec2cadef85] - tools: add script to update c-ares (Richard Lau) #406605daa313215] - tools: notify user if format-md needs to be run (Rich Trott) #406470787c781ce] - tools: abort CQ session when landing several commits (Antoine du Hamel) #40577ddc44ddfd9] - tools: fix commit-lint workflow (Antoine du Hamel) #4067347eddd7076] - tools: avoid unnecessary escaping in markdown formatter (Rich Trott) #40645c700de3705] - tools: avoid fetch extra commits when validating commit messages (Antoine du Hamel) #39128716963484b] - tools: update ESLint to 8.1.0 (Luigi Pinca) #405829cb2116608] - tools: fix formatting of warning message in update-authors.js (Rich Trott) #40600507f1dbc8d] - tools: udpate doc tools to accommodate GFM footnotes (Rich Trott) #40477c2265a92c3] - tools: update license-builder.sh for OpenSSL (Rich Trott) #4054016624b404c] - tools,meta: remove exclusions from AUTHORS (Rich Trott) #40648a95e344fe5] - tty: support more CI services ingetColorDepth(Richie Bendall) #40385b4194ff349] - typings: add more bindings typings (Mestery) #40415da859b56cb] - typings: add JSDoc typings for inspector (Voltrex) #3839090aa96dc44] - typings: improve internal bindings typings (Mestery) #404111e9f3cc522] - typings: separateinternalBindingtypings (Mestery) #40409fbeb895ca6] - (SEMVER-MINOR) v8: multi-tenant promise hook api (Stephen Belanger) #39283