test: fix test-datetime-change-notify after daylight change#40670
test: fix test-datetime-change-notify after daylight change#40670PiotrRybak wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
needs-ci
|
test-linux has failed in #40669 on test-datetime-change-notfy because of today's change in timezone related to daylight saving |
|
Fast-track has been requested by @targos. Please 👍 to approve. |
|
@PiotrRybak thanks for the PR! Could you please update the commit message to fix the typo (notfy -> notify) ? |
Add standard timezone name for Dublin without daylight saving
PiotrRybak
force-pushed
the
fix-datetime-test
branch
from
2d67e0f to
db6785e
Compare
PiotrRybak
changed the title
Fixed it, sorry about that |
| { | ||
| timeZone: 'Europe/Dublin', | ||
| expected: /Irish/, | ||
| expected: /(Irish Standard Time|Greenwich Mean Time)/, |
There was a problem hiding this comment.
It's probably best to avoid unnecessary groups:
| expected: /(Irish Standard Time|Greenwich Mean Time)/, | |
| expected: /Irish Standard Time|Greenwich Mean Time/, |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Mesteery
added
the
author ready
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Note that #40684 exists now. |
It retains @PiotrRybak as the author of the commit that fixes this. Thanks, @PiotrRybak! |
|
For the record, this PR was effectively merged as 747ef34. Thank you for the contribution @PiotrRybak! |
|
Could this go into 16.10.1 ? |
|
Right, thanks. |
8 participants
Add standard timezone name for Dublin without daylight saving