-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: pipeline should drain empty readable #40654
Conversation
@nodejs/streams |
9e5a829
to
8d15eb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@nodejs/tsc this needs another TSC approval |
This needs a rebase against the master branch for one of the tests to pass on the Pi devices. |
This simplifies some cases where the last stream is a Duplex without any expected output. await pipeline(readable, duplex)
8d15eb2
to
181bdf9
Compare
@mcollina I don't think this should be semver-major. wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, ok
Landed in 0a3a601 |
This simplifies some cases where the last stream is a Duplex without any expected output. await pipeline(readable, duplex) PR-URL: #40654 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This simplifies some cases where the last stream is a Duplex without any expected output. await pipeline(readable, duplex) PR-URL: #40654 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This simplifies some cases where the last stream is a Duplex without any expected output. await pipeline(readable, duplex) PR-URL: #40654 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This simplifies some cases where the last stream is a Duplex without any expected output. await pipeline(readable, duplex) PR-URL: #40654 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This simplifies some cases where the last stream is a Duplex
without any expected output.
Related: #40653