Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: response should always emit 'close' #40543

Closed
wants to merge 1 commit into from
Closed

http: response should always emit 'close' #40543

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Oct 21, 2021

Fixes: #40528

@ronag ronag added the http Issues or PRs related to the http subsystem. label Oct 21, 2021
@ronag
Copy link
Member Author

ronag commented Oct 21, 2021

@nodejs/http

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 21, 2021
@ronag ronag added dont-land-on-v12.x and removed needs-ci PRs that need a full CI run. labels Oct 21, 2021
@ronag ronag requested a review from mcollina October 21, 2021 10:28
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40394/

mcollina
mcollina approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 21, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @mcollina. Please 👍 to approve.

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 21, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40397/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 21, 2021 •
edited by ronag
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/40401/ ✅

@ronag ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2021
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 21, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/40543
✔  Done loading data for nodejs/node/pull/40543
----------------------------------- PR info ------------------------------------
Title      http: response should always emit 'close' (#40543)
Author     Robert Nagy  (@ronag)
Branch     ronag:response-close -> nodejs:master
Labels     http, fast-track, author ready, dont-land-on-v12.x, dont-land-on-v14.x, dont-land-on-v16.x
Commits    1
 - http: response should always emit 'close'
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/40543
Fixes: https://github.com/nodejs/node/issues/40528
Reviewed-By: Matteo Collina 
Reviewed-By: Colin Ihrig 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40543
Fixes: https://github.com/nodejs/node/issues/40528
Reviewed-By: Matteo Collina 
Reviewed-By: Colin Ihrig 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 21 Oct 2021 09:41:58 GMT
   ✔  Approvals: 2
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/40543#pullrequestreview-785555237
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40543#pullrequestreview-785715876
   ℹ  This PR is being fast-tracked
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2021-10-21T18:17:57Z: https://ci.nodejs.org/job/node-test-pull-request/40401/
- Querying data for job/node-test-pull-request/40401/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1369244779

This was referenced Oct 22, 2021
Open
Open
Open
Open
@VoltrexKeyva VoltrexKeyva removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 25, 2021
@VoltrexKeyva VoltrexKeyva added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 25, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 25, 2021
@github-actions
Copy link
Contributor

Landed in 070b54a...3b9044b

@github-actions github-actions bot closed this Oct 25, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 25, 2021
@ronag @nodejs-github-bot
http: response should always emit 'close'
3b9044b 
Fixes: #40528

PR-URL: #40543
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Oct 26, 2021
Open
Open
targos pushed a commit that referenced this pull request Nov 6, 2021
@ronag @targos
http: response should always emit 'close'
825a683 
Fixes: #40528

PR-URL: #40543
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

res.destroy() not causing a close event on node v17
6 participants
@ronag @nodejs-github-bot @mcollina @lpinca @cjihrig @VoltrexKeyva