-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: include missing V8 headers in distribution #40526
Conversation
@targos I think |
I can also verify that v8-weak-callback-info.h needs to be added to that list (is referenced from v8-persistent-handle.h https://github.com/nodejs/node/blob/master/deps/v8/include/v8-persistent-handle.h#L10), and then I think, at least my code, builds fine. |
a7ce196
to
dd85e18
Compare
Fast-track has been requested by @targos. Please 👍 to approve. |
Can I have some reviews? I'd like to make a quick release to fix Node.js native addons. |
@nodejs/releasers @nodejs/tsc is one of you available to review (and approve fast-tracking)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Landed in a397009...3ec3ba5 |
Fixes: nodejs/Release#704 PR-URL: #40526 Fixes: #40529 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Fixes: nodejs/Release#704 PR-URL: #40526 Fixes: #40529 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Notable changes: Fixed distribution for native addon builds This release fixes an issue introduced in Node.js v17.0.0, where some V8 headers were missing from the distributed tarball, making it impossible to build native addons. These headers are now included. #40526 Fixed stream issues * Fixed a regression in `stream.promises.pipeline`, which was introduced in version 16.10.0, is fixed. It is now possible again to pass an array of streams to the function. #40193 * Fixed a bug in `stream.Duplex.from`, which didn't work properly when an async generator function was passed to it. #40499 PR-URL: #40535
Notable changes: Fixed distribution for native addon builds This release fixes an issue introduced in Node.js v17.0.0, where some V8 headers were missing from the distributed tarball, making it impossible to build native addons. These headers are now included. #40526 Fixed stream issues * Fixed a regression in `stream.promises.pipeline`, which was introduced in version 16.10.0, is fixed. It is now possible again to pass an array of streams to the function. #40193 * Fixed a bug in `stream.Duplex.from`, which didn't work properly when an async generator function was passed to it. #40499 PR-URL: #40535
Fixes: nodejs/Release#704
Fixes: #40529