Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: correct the codeblock for hmacImportParams.hash #40340

Closed
wants to merge 1 commit into from
Closed

doc: correct the codeblock for hmacImportParams.hash #40340

wants to merge 1 commit into from

Conversation

J-Human
Copy link
Contributor

@J-Human J-Human commented Oct 6, 2021

It seems the first back-tick is missing and was accidentally replaced by a single quote.

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Oct 6, 2021
@Lxxyx Lxxyx added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

Fast-track has been requested by @Lxxyx. Please 👍 to approve.

@Flarna Flarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

Landed in 87da53c...f1c196d

@github-actions github-actions bot closed this Oct 6, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 6, 2021
@J-Human @nodejs-github-bot
doc: correct the codeblock for hmacImportParams.hash
f1c196d 
PR-URL: #40340
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@J-Human J-Human deleted the doc/fix-hmacimportparams-typo branch October 6, 2021 23:35
danielleadams pushed a commit that referenced this pull request Oct 7, 2021
@J-Human @danielleadams
doc: correct the codeblock for hmacImportParams.hash
8d0546d 
PR-URL: #40340
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@danielleadams danielleadams mentioned this pull request Oct 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@J-Human @Trott @benjamingr @Lxxyx @Flarna @nodejs-github-bot