-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: set DESTCPU correctly for 'make binary' on Apple Silicon #40147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
needs-ci
PRs that need a full CI run.
labels
Sep 18, 2021
cheister
force-pushed
the
apple-silicon-build-binary
branch
from
September 18, 2021 23:49
8dd0e91
to
03306d9
Compare
cheister
changed the title
Set DESTCPU correctly on Apple Silicon so 'make binary' builds
build: set DESTCPU correctly for 'make binary' on Apple Silicon
Sep 18, 2021
targos
approved these changes
Sep 19, 2021
targos
reviewed
Sep 19, 2021
jasnell
approved these changes
Sep 20, 2021
mhdawson
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lpinca
approved these changes
Sep 23, 2021
targos
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Sep 26, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 26, 2021
21 tasks
This was referenced Sep 28, 2021
richardlau
approved these changes
Sep 29, 2021
richardlau
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 29, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 29, 2021
Landed in 88b497a...5607de8 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 29, 2021
PR-URL: #40147 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
This was referenced Sep 30, 2021
22 tasks
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
PR-URL: #40147 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
This was referenced Oct 5, 2021
evanlucas
pushed a commit
to evanlucas/node
that referenced
this pull request
Feb 5, 2022
PR-URL: nodejs#40147 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
evanlucas
pushed a commit
to evanlucas/node
that referenced
this pull request
Feb 5, 2022
PR-URL: nodejs#40147 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Backport-PR-URL: nodejs#41855
evanlucas
pushed a commit
to evanlucas/node
that referenced
this pull request
Apr 15, 2022
PR-URL: nodejs#40147 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Backport-PR-URL: nodejs#41855
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
build
Issues and PRs related to build files or the CI.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
make binary -j8
on an Apple Silicon M1 it looks like the DESTCPU is not set correctly in the Makefile so you get the following error when building opensslOn the M1 I get
arm64
foruname -m
. This PR sets the DESTCPU to arm64 and everything builds fine after that.