Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-domain-with-abort-on-uncaught-exception.js on AIX #4008

Closed

Conversation

dnakamura
Copy link
Contributor

Add SIGTRAP as an expected signal when running on AIX. To fix failing test. see #3239

backport of f45c315 for v0.12

Add SIGTRAP as an expected signal when running on AIX.

Port of f45c315 for v0.12
@cjihrig
Copy link
Contributor

cjihrig commented Nov 24, 2015

LGTM if the CI is happy

@mscdex mscdex added domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests. v0.12 labels Nov 24, 2015
@mhdawson
Copy link
Member

@dnakamura, I think the original issue was seen on platforms other than AIX and was fixed so that it resolved those cases as well. Is the test in 0.12.X such that the fix was only needed for AIX ? Otherwise we should probably fix in a way similar to the original where it applies across platforms

@dnakamura
Copy link
Contributor Author

Yeah, however the style of the test in this case is aimed more on a case by case basis. Not entirely sure on how to implement while keeping with the style of the test

@mhdawson
Copy link
Member

Probably worth looking at the original issue to see what other platforms needed the same fix then at least we can include them in the if with AIX

@dnakamura
Copy link
Contributor Author

Actually if those platforms indicate the signal in the return code, it should be simple

@mhdawson
Copy link
Member

Ok, good to hear. I assume you'll update the patch to cover them

@mhdawson
Copy link
Member

Devin do you have an idea when you'll have the update covering the other platforms ?

@mhdawson
Copy link
Member

@dnakamura just wondering if you'll get to this soon

@jasnell
Copy link
Member

jasnell commented Apr 12, 2016

@dnakamura ... ping

@jasnell jasnell added the stalled Issues and PRs that are stalled. label Apr 12, 2016
@rvagg
Copy link
Member

rvagg commented May 5, 2016

ping, what's the status of this? we'll be at the end of v0.12 soon!

@mhdawson
Copy link
Member

mhdawson commented May 9, 2016

Going to ask @iwuzhere if he can take this one over

@imran-iq
Copy link
Contributor

imran-iq commented May 10, 2016

Shouldn't this already be fixed with 018e4e0?

Which looks like a back port 425a354 that should resolve the "other platforms" being mentioned

@mhdawson
Copy link
Member

mhdawson commented May 10, 2016

I'd agree with @iwuzhere I think this can just be closed. I'll close if anybody disagrees please re-open.

This was referenced Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain Issues and PRs related to the domain subsystem. stalled Issues and PRs that are stalled. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants