[v14.x backport] async_hooks: use resource stack for AsyncLocalStorage run #39974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: nodejs#39890 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Qard
added
async_hooks
Qard
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Member
|
The commit lands cleanly on my side and all tests pass. Did you change something to open this PR? |
Member
Author
|
Ah, nope. It lands cleanly. |
Member
|
Okay, I pushed it in 5a42be9. If you want to make sure a change lands on LTS, it should be sufficient to add the |
Member
Author
|
Ah, good to know, thanks! Sorry, I'm still learning how all the backporting stuff works. 😅 |
Member
|
No worries. I know everything is not clear about backporting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #39890
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Vladimir de Turckheim vlad2t@hotmail.com
Reviewed-By: Gerhard Stöbich deb2001-github@yahoo.de
Reviewed-By: Minwoo Jung nodecorelab@gmail.com
Reviewed-By: Zijian Liu lxxyxzj@gmail.com