Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add triagers to the table of contents. #39969

Merged
merged 1 commit into from
Oct 3, 2021
Merged

doc: add triagers to the table of contents. #39969

merged 1 commit into from
Oct 3, 2021

Conversation

iam-frankqiu
Copy link
Contributor

I think we should add Triagers to the table of contents for Collaborators and Release keys have already in.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 1, 2021
@targos
Copy link
Member

targos commented Sep 1, 2021

I'd also support just removing the table of contents as GitHub now generates one automatically:

image

@iam-frankqiu
Copy link
Contributor Author

I'd also support just removing the table of contents as GitHub now generates one automatically:

image

Is the GitHub client?

@targos
Copy link
Member

targos commented Sep 1, 2021

Is the GitHub client?

The website: https://github.com/nodejs/node#readme

@iam-frankqiu
Copy link
Contributor Author

Is the GitHub client?

The website: https://github.com/nodejs/node#readme

In case someone doesn't notice this button like me, we should still keep it.

@lpinca
Copy link
Member

lpinca commented Sep 1, 2021

There is a typo in commit title: conents -> contents.

@iam-frankqiu
Copy link
Contributor Author

There is a typo in commit title: conents -> contents.

Sorry. I will be more careful next time. Hope it won't affect landing.

@iam-frankqiu iam-frankqiu added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 3, 2021
@jasnell
Copy link
Member

jasnell commented Sep 3, 2021

Landed in 17098b2ef69c

@jasnell jasnell closed this Sep 3, 2021
@iam-frankqiu
Copy link
Contributor Author

Landed in 17098b2ef69c

I don't know why. But it seems like not landed successfully.

@iam-frankqiu iam-frankqiu reopened this Oct 3, 2021
@iam-frankqiu @Trott
doc: add triagers to the table of contents
1811396 
PR-URL: nodejs#39969
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 3, 2021

Landed in 1811396

@Trott Trott merged commit 1811396 into nodejs:master Oct 3, 2021
targos pushed a commit that referenced this pull request Oct 4, 2021
@iam-frankqiu @targos
doc: add triagers to the table of contents
f71ac57 
PR-URL: #39969
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@iam-frankqiu @targos @lpinca @jasnell @Trott @tniessen @richardlau @gireeshpunathil @nodejs-github-bot