Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip test if in FreeBSD jail #3995

Closed
wants to merge 1 commit into from
Closed

test: skip test if in FreeBSD jail #3995

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 24, 2015

Test is flaky in FreeBSD jail but robust otherwise.

Fixes: #2475

@Trott Trott added test Issues and PRs related to the tests. freebsd Issues and PRs related to the FreeBSD platform. labels Nov 24, 2015
@mscdex mscdex added the net Issues and PRs related to the net subsystem. label Nov 24, 2015
@rvagg
Copy link
Member

rvagg commented Nov 24, 2015

lgtm

@jbergstroem
Copy link
Member

Sure, LGTM

@bnoordhuis
Copy link
Member

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Nov 24, 2015

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Nov 24, 2015

CI: https://ci.nodejs.org/job/node-test-pull-request/828/

@Trott
Copy link
Member Author

Trott commented Nov 25, 2015

Landed in b061e3a

@Trott Trott closed this Nov 25, 2015
Trott added a commit that referenced this pull request Nov 25, 2015
@Trott
test: skip test if in FreeBSD jail
b061e3a 
Test test-net-socket-local-address is flaky in FreeBSD jail but robust
otherwise.

Fixes: #2475
PR-URL: #3995
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Nov 26, 2015
Closed
Trott added a commit that referenced this pull request Dec 1, 2015
@Trott
test: skip test if in FreeBSD jail
5702eef 
Test test-net-socket-local-address is flaky in FreeBSD jail but robust
otherwise.

Fixes: #2475
PR-URL: #3995
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott added a commit that referenced this pull request Dec 4, 2015
@Trott @rvagg
test: skip test if in FreeBSD jail
d184c70 
Test test-net-socket-local-address is flaky in FreeBSD jail but robust
otherwise.

Fixes: #2475
PR-URL: #3995
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott added a commit that referenced this pull request Dec 5, 2015
@Trott @rvagg
test: skip test if in FreeBSD jail
19ed33d 
Test test-net-socket-local-address is flaky in FreeBSD jail but robust
otherwise.

Fixes: #2475
PR-URL: #3995
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Dec 8, 2015
Closed
Merged
@jasnell jasnell mentioned this pull request Dec 17, 2015
Closed
Trott added a commit that referenced this pull request Dec 17, 2015
@Trott @jasnell
test: skip test if in FreeBSD jail
38ba152 
Test test-net-socket-local-address is flaky in FreeBSD jail but robust
otherwise.

Fixes: #2475
PR-URL: #3995
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott added a commit that referenced this pull request Dec 23, 2015
@Trott @jasnell
test: skip test if in FreeBSD jail
f516200 
Test test-net-socket-local-address is flaky in FreeBSD jail but robust
otherwise.

Fixes: #2475
PR-URL: #3995
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
test: skip test if in FreeBSD jail
56efb3d 
Test test-net-socket-local-address is flaky in FreeBSD jail but robust
otherwise.

Fixes: nodejs#2475
PR-URL: nodejs#3995
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott Trott deleted the skip-jail branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
freebsd Issues and PRs related to the FreeBSD platform. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @rvagg @jbergstroem @bnoordhuis @cjihrig @mscdex @jasnell @MylesBorins