Skip to content

events: fix duplicate require which cause performance penalty #39892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

events: fix duplicate require which cause performance penalty #39892

wants to merge 1 commit into from

Conversation

@wwwzbwcom
Copy link
Contributor

@wwwzbwcom wwwzbwcom commented Aug 26, 2021 •
edited
Loading

Inspect require multiple times in events

@nodejs-github-bot nodejs-github-bot added events Issues and PRs related to the events subsystem / EventEmitter. needs-ci PRs that need a full CI run. labels Aug 26, 2021
VoltrexKeyva
VoltrexKeyva reviewed Aug 26, 2021
View reviewed changes
VoltrexKeyva
VoltrexKeyva reviewed Aug 26, 2021
View reviewed changes
mscdex
mscdex reviewed Aug 26, 2021
View reviewed changes
@wwwzbwcom
Copy link
Contributor Author

wwwzbwcom commented Aug 26, 2021

how can I restart the CI?

@VoltrexKeyva
Copy link
Member

VoltrexKeyva commented Aug 26, 2021

how can I restart the CI?

You don't really need to but if you want, you can do that by either closing and re-opening the PR or force pushing your latest commit again with no changes using the git CLI's push subcommand with using both of the options of --amend and --force (-f as an alias).

The force pushing method is recommended.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 27, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/39687/ 💛

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 27, 2021
@jasnell
Copy link
Member

jasnell commented Sep 3, 2021

Something wierd happened in this PR. The commit message is from the release while the actual change is correct. The commit message will need to be fixed before this can land. Removing the author ready label.

@jasnell jasnell removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 3, 2021
@wwwzbwcom
Copy link
Contributor Author

wwwzbwcom commented Sep 3, 2021

Something wierd happened in this PR. The commit message is from the release while the actual change is correct. The commit message will need to be fixed before this can land. Removing the author ready label.

fixed

@Ayase-252
Copy link
Member

Ayase-252 commented Sep 13, 2021

@wwwzbwcom, It seems still some weird here. The author of the commit is targos not you.

Do you mind do a rebase and fix the problem of commit author?

@wwwzbwcom
Copy link
Contributor Author

wwwzbwcom commented Sep 15, 2021

@wwwzbwcom, It seems still some weird here. The author of the commit is targos not you.

Do you mind do a rebase and fix the problem of commit author?

done

@Ayase-252 Ayase-252 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 15, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39949/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 15, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39951/

@Ayase-252 Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 15, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2021

Landed in bea8a90...4a31ea0

@github-actions github-actions bot closed this Sep 15, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 15, 2021
@wwwzbwcom @nodejs-github-bot
events: fix duplicate require which cause performance penalty
4a31ea0 
PR-URL: #39892
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
This was referenced Sep 18, 2021
Open
Open
Open
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@wwwzbwcom @BethGriggs
events: fix duplicate require which cause performance penalty
a09e187 
PR-URL: #39892
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@wwwzbwcom @BethGriggs
events: fix duplicate require which cause performance penalty
f666f5a 
PR-URL: #39892
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
This was referenced Sep 22, 2021
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@JungMinu JungMinu JungMinu approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

+2 more reviewers

@mscdex mscdex mscdex left review comments

@Linkgoron Linkgoron Linkgoron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. events Issues and PRs related to the events subsystem / EventEmitter. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.