meta: update AUTHORS #39874
Closed
meta: update AUTHORS #39874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
meta
Trott
approved these changes
Aug 25, 2021
targos
approved these changes
Aug 25, 2021
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
lpinca
approved these changes
Aug 25, 2021
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/39874 ✔ Done loading data for nodejs/node/pull/39874 ----------------------------------- PR info ------------------------------------ Title meta: update AUTHORS (#39874) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch undefined:actions/authors-update -> nodejs:master Labels meta, fast-track Commits 1 - meta: update AUTHORS Committers 1 - github-actions[bot] PR-URL: https://github.com/nodejs/node/pull/39874 Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39874 Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 25 Aug 2021 04:10:23 GMT ✔ Approvals: 3 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/39874#pullrequestreview-737879844 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/39874#pullrequestreview-737916995 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/39874#pullrequestreview-738374612 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1166744069 |
github-actions
bot
added
the
commit-queue-failed
|
I wonder why GitHub CI isn't running for this. |
GitHub actions cannot be triggered by events that are generated by the default token of another action. The solution is to use |
jasnell
approved these changes
Aug 25, 2021
tniessen
approved these changes
Aug 25, 2021
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 27, 2021
|
Closing until #39907 or something like it lands, at which point we'll run the workflow again and see if we have GitHub CI running on the PR or not. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 29, 2021
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 30, 2021
Refs: #39874 (comment) PR-URL: #39907 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
removed
the
commit-queue-failed
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
Refs: #39874 (comment) PR-URL: #39907 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
Refs: #39874 (comment) PR-URL: #39907 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this PR exists, there's presumably new additions to the AUTHORS file. This is an automatically generated PR by the
authors.ymlGitHub Action, which runstools/update-authors.jsand submits a new PR or updates an existing PR.Please note that there might be duplicate entries. If there are, please remove them and add the duplicate emails to .mailmap directly to this PR.