Skip to content

src: remove extra semicolons outside fns#39800

Closed
codebytere wants to merge 1 commit intonodejs:masterfrom
codebytere:semicolns
Closed

src: remove extra semicolons outside fns#39800
codebytere wants to merge 1 commit intonodejs:masterfrom
codebytere:semicolns

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Aug 18, 2021

Fixes the following:

../../third_party/electron_node/src/node_blob.cc:500:65: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
NODE_MODULE_CONTEXT_AWARE_INTERNAL(blob, node::Blob::Initialize);
                                                                ^
../../third_party/electron_node/src/node_blob.cc:501:77: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
NODE_MODULE_EXTERNAL_REFERENCE(blob, node::Blob::RegisterExternalReferences);
                                                                            ^
2 errors generated.

@codebytere codebytere requested a review from jasnell August 18, 2021 16:06
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 18, 2021
@mscdex
Copy link
Contributor

mscdex commented Aug 18, 2021

Is this a rule we should add to node core?

jasnell
jasnell approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muscle-memory is a heck of thing. It would be good to see if we can get the c linter to catch these.

@jasnell jasnell added the fast-track PRs that do not need to wait for 72 hours to land. label Aug 18, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2021

Fast-track has been requested by @jasnell. Please 👍 to approve.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 22, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39636/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 24, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39652/

@codebytere
Copy link
Member Author

codebytere commented Aug 25, 2021

Landed in eeb86fb

@codebytere codebytere closed this Aug 25, 2021
@codebytere codebytere deleted the semicolns branch August 25, 2021 07:48
codebytere added a commit that referenced this pull request Aug 25, 2021
@codebytere
src: remove extra semicolons outside fns
eeb86fb 
PR-URL: #39800
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2021
@codebytere @targos
src: remove extra semicolons outside fns
79ce096 
PR-URL: #39800
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request Sep 6, 2021
Merged
codebytere added a commit to electron/electron that referenced this pull request Sep 8, 2021
@codebytere
src: remove extra semicolons outside fns
412542f 
nodejs/node#39800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@sxa sxa sxa approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 72 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.