Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix inspector_protocol compiler warnings #39725

Closed
wants to merge 3 commits into from
Closed

tools: fix inspector_protocol compiler warnings #39725

wants to merge 3 commits into from

Commits on Aug 10, 2021

  1. tools: cherry-pick ffb34b6 

    Original commit message:

    tools: fix compiler warning in inspector_protocol

    error: comparison of integer expressions of different signedness:
    ‘int’ and ‘uint64_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
     2562 |           if (!success || std::numeric_limits<int32_t>::max() <
          |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
     2563 |                               token_start_internal_value_) {
          |                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~

    PR-URL: nodejs#37573
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    @RaisinTen @richardlau
    RaisinTen authored and richardlau committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    1c2c34a View commit details
    Browse the repository at this point in the history

  2. tools: fix more build warnings in inspector_protocol

    @richardlau
    richardlau committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    e79973c View commit details
    Browse the repository at this point in the history

  3. build: run coverage for inspector protocol changes 

    The inspector protocol currently lives in `tools`.
    @richardlau
    richardlau committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    44104c6 View commit details
    Browse the repository at this point in the history