doc: update min mac ver + move mac arm64 to tier 1 #39586
Conversation
nodejs-github-bot
added
build
|
/cc @nodejs/build |
BUILDING.md
Outdated
| | Windows | arm64 | >= Windows 10 | Tier 2 (compiling) / Experimental (running) | | | ||
| | macOS | x64 | >= 10.13 | Tier 1 | | | ||
| | macOS | arm64 | >= 11 | Experimental | | | ||
| | macOS | x64 | >= 10.14.4 | Tier 1 | | |
There was a problem hiding this comment.
Actually do the binaries run on macOS 10.13? This table is the table of platforms we support running Node.js on but not a guarantee that you can build on this (building requirements are under the "Supported toolchains" section below).
The reason for asking is that usually we wouldn't change this table during a release (e.g. 16.x) and would normally consider raising versions to be semver-major.
There was a problem hiding this comment.
No idea as we dont test on 10.13 - the minimum version is set to target 10.13 but I dont think its ever been verified.
There was a problem hiding this comment.
This number really should match MACOSX_DEPLOYMENT_TARGET in common.gypi, and also see lines 175 and 176 below in this file.
MACOSX_DEPLOYMENT_TARGET has been a pretty solid tool historically for Node.js, it compiles the binaries to be compatible with the version we set there, even though we haven't always (maybe never) tested that far back. I think we should either match that value here (update it, or update this), or have some kind of note which makes it clear that we compile binaries to be supported on that version.
If you feel strongly enough that this column should be out of sync with MACOSX_DEPLOYMENT_TARGET then I'd suggest using the Notes column to describe what we do and that binaries in theory should be compatible back to that version but we recommend running it with the version you're putting here.
There was a problem hiding this comment.
I prefer that approach - Ill change this back to 10.13 and add an note making it explicit that whilst we supporting our own binaries running on that level we dont necessarily support compiling at that level.
AshCripps
force-pushed
the
update-mac-doc
branch
from
f533a48 to
d955400
Compare
AshCripps
force-pushed
the
update-mac-doc
branch
from
d955400 to
2c13ac5
Compare
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
LGTM with lint warnings fixed.
BUILDING.md
Outdated
| However there is no guarantee compiling on 10.13 will work as Xcode11 is required | ||
| to compile. |
There was a problem hiding this comment.
| However there is no guarantee compiling on 10.13 will work as Xcode11 is required | |
| to compile. | |
| However there is no guarantee compiling on 10.13 will work as Xcode11 is | |
| required to compile. |
Lint.
Update the minimum macos version that can compile to match the xcode requirements. Also move mac arm64 to tier 1. refs: nodejs#39584 (comment)
AshCripps
force-pushed
the
update-mac-doc
branch
from
2c13ac5 to
e03347f
Compare
targos
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 4f9fd8d...4d60ee8 |
Update the minimum macos version that can compile to match the xcode requirements. Also move mac arm64 to tier 1. refs: #39584 (comment) PR-URL: #39586 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Update the minimum macos version that can compile to match the xcode requirements. Also move mac arm64 to tier 1. refs: #39584 (comment) PR-URL: #39586 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
10 participants
Update the minimum macos version that can compile to match the
xcode requirements.
Also move mac arm64 to tier 1.
refs: #39584 (comment)