Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: do not include legacy getter/setter methods in completion #39576

Closed
wants to merge 2 commits into from
Closed

repl: do not include legacy getter/setter methods in completion #39576

wants to merge 2 commits into from

Commits on Jul 29, 2021

  1. repl: do not include legacy getter/setter methods in completion 

    For every object that inherits from `Object.prototype`, the REPL
includes the `Object.prototype` methods in its autocompletion.

This is already a little noisy, but in particular, this also
includes the legacy `__defineGetter__` family of methods;
since those are deprecated and not in practical use anymore,
it helps reduce noise a bit to remove them.

This commit does not remove `__proto__` as it is a little
more popular and, despite its downsides, a slightly more convenient
way to access the prototype of an object in the REPL than
`Object.getPrototypeOf(...)`.
    @addaleax
    addaleax committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    434dcd7 View commit details
    Browse the repository at this point in the history

  2. fixup! repl: do not include legacy getter/setter methods in completion

    @addaleax
    addaleax committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    236a258 View commit details
    Browse the repository at this point in the history