Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: small code cleanup #3943

Closed
wants to merge 1 commit into from
Closed

net: small code cleanup #3943

wants to merge 1 commit into from

Conversation

jscissr
Copy link
Contributor

@jscissr jscissr commented Nov 20, 2015

options is already a param of the function.

`options` is already a param of the function.
@cjihrig
Copy link
Contributor

cjihrig commented Nov 20, 2015

LGTM. This is likely left over from when Server() used arguments.

@evanlucas
Copy link
Contributor

LGTM

1 similar comment
@targos
Copy link
Member

targos commented Nov 20, 2015

LGTM

@evanlucas
Copy link
Contributor

@MylesBorins
Copy link
Contributor

LGTM

@mscdex mscdex added the net Issues and PRs related to the net subsystem. label Nov 20, 2015
jasnell pushed a commit that referenced this pull request Nov 20, 2015
`options` is already a param of the function.

PR-URL: #3943
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Nov 20, 2015

Landed in 9472a0c

@jasnell jasnell closed this Nov 20, 2015
@jscissr jscissr deleted the patch-1 branch November 21, 2015 00:34
rvagg pushed a commit that referenced this pull request Dec 5, 2015
`options` is already a param of the function.

PR-URL: #3943
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@rvagg rvagg mentioned this pull request Dec 17, 2015
MylesBorins pushed a commit that referenced this pull request Dec 29, 2015
`options` is already a param of the function.

PR-URL: #3943
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
`options` is already a param of the function.

PR-URL: #3943
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
net Issues and PRs related to the net subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants