Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: avoid test timeouts on rpi #3902

Closed
wants to merge 1 commit into from

Conversation

stefanmb
Copy link
Contributor

Generating 1024-bit primes on rpi test machines sometimes causes timeouts. We can avoid this situation by using 256-bit primes when not running in FIPS mode.

Resolves #3881.

Generating 1024-bit primes on rpi test machines sometimes
causes timeouts. Avoid this situation by using 256-bit
primes when not running in FIPS mode.
@mscdex mscdex added test Issues and PRs related to the tests. arm Issues and PRs related to the ARM platform. labels Nov 18, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Nov 18, 2015

LGTM

@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Nov 18, 2015
@mscdex
Copy link
Contributor

mscdex commented Nov 18, 2015

LGTM

@bnoordhuis
Copy link
Member

@stefanmb
Copy link
Contributor Author

I see two unrelated things:
(1) EADDRNOTAVAIL 127.0.0.1:12346 on OS X [1].
(2) test-fs-utimes.js on rpi [2]

@jasnell
Copy link
Member

jasnell commented Nov 18, 2015

Landed in da9a89a

@Fishrock123
Copy link
Contributor

Umm, won't this mean the whole CI tests with 256-bit primes now since it doesn't use FIPS?

@stefanmb
Copy link
Contributor Author

@Fishrock123 Correct, which is the exact situation we had before my previous commit. Separately, there has been discussion about introducing FIPS builds into CI.

jasnell pushed a commit that referenced this pull request Nov 18, 2015
Generating 1024-bit primes on rpi test machines sometimes
causes timeouts. Avoid this situation by using 256-bit
primes when not running in FIPS mode.

Fixes: #3881
PR-URL: #3902
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <ben@strongloop.com>
@jasnell
Copy link
Member

jasnell commented Nov 18, 2015

Exactly, this reverts the behavior back to where it was before when FIPS is not enabled.

MylesBorins pushed a commit that referenced this pull request Dec 1, 2015
Generating 1024-bit primes on rpi test machines sometimes
causes timeouts. Avoid this situation by using 256-bit
primes when not running in FIPS mode.

PR-URL: #3902
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <ben@strongloop.com>
rvagg pushed a commit that referenced this pull request Dec 4, 2015
Generating 1024-bit primes on rpi test machines sometimes
causes timeouts. Avoid this situation by using 256-bit
primes when not running in FIPS mode.

PR-URL: #3902
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <ben@strongloop.com>
rvagg pushed a commit that referenced this pull request Dec 5, 2015
Generating 1024-bit primes on rpi test machines sometimes
causes timeouts. Avoid this situation by using 256-bit
primes when not running in FIPS mode.

Fixes: #3881
PR-URL: #3902
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <ben@strongloop.com>
@jasnell jasnell mentioned this pull request Dec 17, 2015
jasnell pushed a commit that referenced this pull request Dec 17, 2015
Generating 1024-bit primes on rpi test machines sometimes
causes timeouts. Avoid this situation by using 256-bit
primes when not running in FIPS mode.

PR-URL: #3902
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <ben@strongloop.com>
jasnell pushed a commit that referenced this pull request Dec 23, 2015
Generating 1024-bit primes on rpi test machines sometimes
causes timeouts. Avoid this situation by using 256-bit
primes when not running in FIPS mode.

PR-URL: #3902
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <ben@strongloop.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants