Skip to content

Revert "build: work around bug in MSBuild v16.10.0" #38977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "build: work around bug in MSBuild v16.10.0" #38977

wants to merge 1 commit into from

Conversation

@targos
Copy link
Member

@targos targos commented Jun 9, 2021

This reverts commit 3457130.

Visual Studio v16.10.1 is out.

Closes: #38872

@targos
Revert "build: work around bug in MSBuild v16.10.0"
fe09ae3 
This reverts commit 3457130.

Visual Studio v16.10.1 is out.

Closes: nodejs#38872
@github-actions github-actions bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform. labels Jun 9, 2021
@targos
Copy link
Member Author

targos commented Jun 9, 2021

I do not expect this to work immediately on GitHub actions because they probably haven't updated yet.

@targos
Copy link
Member Author

targos commented Jun 9, 2021

Confirmed it works on my computer:

PS C:\git\nodejs\node> .\vcbuild.bat
Looking for Python
Python found in C:\Users\targo\AppData\Local\Microsoft\WindowsApps\\python.exe
Looking for NASM
Looking for Visual Studio 2019
calling: "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\\Auxiliary\Build\vcvarsall.bat" amd64
**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.10.1
** Copyright (c) 2021 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'
Found MSVS version 16.0
configure  --dest-cpu=x64
Node.js configure: Found Python 3.9.5...
←[1m←[32mINFO←[0m: configure completed successfully
Project files generated.
  default-foreground-task-runner.cc
  hdr_histogram.c
...

@targos targos added the blocked PRs that are blocked by other issues or PRs. label Jun 11, 2021
@targos
Copy link
Member Author

targos commented Jun 11, 2021

I think it will work after actions/runner-images#3554 is merged.

@aduh95 aduh95 removed the blocked PRs that are blocked by other issues or PRs. label Jun 14, 2021
@aduh95
Copy link
Contributor

aduh95 commented Jun 14, 2021

I think it will work after actions/virtual-environments#3554 is merged.

This has been merged, I've restarted the Windows Actions to confirm the workaround is no longer necessary.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 14, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 14, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 14, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38627/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 15, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 15, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2021

Landed in 7a9635b...842554f

@github-actions github-actions bot closed this Jun 15, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jun 15, 2021
@targos @nodejs-github-bot
Revert "build: work around bug in MSBuild v16.10.0"
842554f 
This reverts commit 3457130.

Visual Studio v16.10.1 is out.

Closes: #38872

PR-URL: #38977
Fixes: #38872
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos deleted the revert-msbuild-workaround branch June 15, 2021 06:39
danielleadams pushed a commit that referenced this pull request Jun 21, 2021
@targos @danielleadams
Revert "build: work around bug in MSBuild v16.10.0"
7f225a0 
This reverts commit 3457130.

Visual Studio v16.10.1 is out.

Closes: #38872

PR-URL: #38977
Fixes: #38872
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 21, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@targos @richardlau
Revert "build: work around bug in MSBuild v16.10.0"
5cfff80 
This reverts commit 3457130.

Visual Studio v16.10.1 is out.

Closes: #38872

PR-URL: #38977
Fixes: #38872
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@targos @richardlau
Revert "build: work around bug in MSBuild v16.10.0"
6962c64 
This reverts commit 3457130.

Visual Studio v16.10.1 is out.

Closes: #38872

PR-URL: #38977
Fixes: #38872
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@targos @foxxyz
Revert "build: work around bug in MSBuild v16.10.0"
b9aee14 
This reverts commit 3457130.

Visual Studio v16.10.1 is out.

Closes: nodejs#38872

PR-URL: nodejs#38977
Fixes: nodejs#38872
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows build fails with Visual Studio 2019 v16.10

6 participants

@targos @aduh95 @nodejs-github-bot @jasnell @lpinca @cjihrig