Skip to content

test: refactor test-readline-interface to be shorter #38691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+9 −27
Closed

test: refactor test-readline-interface to be shorter #38691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 9 additions & 27 deletions test/parallel/test-readline-interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,34 +87,16 @@ function assertCursorRowsAndCols(rli, rows, cols) {
const input = new FakeInput();

// Constructor throws if completer is not a function or undefined
assert.throws(() => {
readline.createInterface({
input,
completer: 'string is not valid'
});
}, {
name: 'TypeError',
code: 'ERR_INVALID_ARG_VALUE'
});

assert.throws(() => {
readline.createInterface({
input,
completer: ''
});
}, {
name: 'TypeError',
code: 'ERR_INVALID_ARG_VALUE'
});

assert.throws(() => {
readline.createInterface({
input,
completer: false
['not an array', 123, 123n, {}, true, Symbol(), null].forEach((invalid) => {
assert.throws(() => {
readline.createInterface({
input,
completer: invalid
});
}, {
name: 'TypeError',
code: 'ERR_INVALID_ARG_VALUE'
});
}, {
name: 'TypeError',
code: 'ERR_INVALID_ARG_VALUE'
});

// Constructor throws if history is not an array
Expand Down