Skip to content

test: improve coverage of lib/readline.js#38646

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
pd4d10:patch-test-readline
May 12, 2024
Merged

test: improve coverage of lib/readline.js#38646
nodejs-github-bot merged 1 commit intonodejs:mainfrom
pd4d10:patch-test-readline

Conversation

@pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented May 12, 2021

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 12, 2021
@pd4d10 pd4d10 force-pushed the patch-test-readline branch from 5917371 to 7489b03 Compare May 12, 2021 09:25
mhdawson
mhdawson approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented May 14, 2021

CI run: https://ci.nodejs.org/job/node-test-pull-request/38092/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 14, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38092/

@Lxxyx
Copy link
Member

Lxxyx commented Jun 11, 2021

Hi, thanks for submitting the code. could you resolve git conflicts? @pd4d10

@pd4d10
Copy link
Contributor Author

pd4d10 commented Jun 11, 2021

Updated @Lxxyx

@Lxxyx Lxxyx added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Jun 12, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 12, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 12, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38592/

@Lxxyx Lxxyx added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 3, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39746/

@pd4d10 pd4d10 force-pushed the patch-test-readline branch from 9328554 to 2881cb9 Compare April 3, 2022 17:21
@aduh95
Copy link
Contributor

aduh95 commented May 5, 2024

This needs a rebase

@aduh95 aduh95 added the stalled Issues and PRs that are stalled. label May 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2024

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

@pd4d10 pd4d10 force-pushed the patch-test-readline branch from 2881cb9 to 9b9edd6 Compare May 6, 2024 05:34
@pd4d10
Copy link
Contributor Author

pd4d10 commented May 6, 2024 •
edited
Loading

This needs a rebase

@aduh95 Updated

@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed stalled Issues and PRs that are stalled. labels May 6, 2024
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 10, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59078/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 11, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59089/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 11, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59126/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2024
@nodejs-github-bot nodejs-github-bot merged commit 749b0bf into nodejs:main May 12, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 12, 2024

Landed in 749b0bf

@pd4d10 pd4d10 deleted the patch-test-readline branch May 12, 2024 10:46
targos pushed a commit that referenced this pull request May 12, 2024
@pd4d10 @targos
test: improve coverage of lib/readline.js
ea6070b 
PR-URL: #38646
Refs: https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request May 13, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@pd4d10 @marco-ippolito
test: improve coverage of lib/readline.js
5f8c013 
PR-URL: #38646
Refs: https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@pd4d10 @marco-ippolito
test: improve coverage of lib/readline.js
c48e55e 
PR-URL: #38646
Refs: https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@pd4d10 @marco-ippolito
test: improve coverage of lib/readline.js
0be8123 
PR-URL: #38646
Refs: https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@pd4d10 @eliphazbouye
test: improve coverage of lib/readline.js
c1eb445 
PR-URL: nodejs#38646
Refs: https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@pd4d10 @bmeck
test: improve coverage of lib/readline.js
a53ef44 
PR-URL: nodejs#38646
Refs: https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@mhdawson mhdawson mhdawson approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@aduh95 aduh95 aduh95 approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@pd4d10 @mhdawson @nodejs-github-bot @Lxxyx @aduh95 @jasnell @Trott @VoltrexKeyva @avivkeller