Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: https://github.com/nodejs/node/issues/38606 #38610

Closed
wants to merge 6 commits into from
Closed

Fixes: https://github.com/nodejs/node/issues/38606 #38610

wants to merge 6 commits into from

Conversation

ihiteshsharma
Copy link
Contributor

@ihiteshsharma ihiteshsharma commented May 9, 2021 •
edited by aduh95
Loading

Fixes: #38606

@github-actions github-actions bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 9, 2021
mscdex
mscdex reviewed May 9, 2021
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
mscdex
mscdex reviewed May 9, 2021
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
marsonya
marsonya requested changes May 11, 2021
View reviewed changes
Copy link
Member

@marsonya marsonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly move the section writeStream.close([callback]) below writeStream.bytesWritten to maintain the ASCII order based on headings

@ihiteshsharma
Copy link
Contributor Author

Hi, thank you for your comments. Please see if everything looks okay. This is my first ever issue that I have contributed to. So any other pointers or direction that I should keep in mind going forward contributing to other issues will be appreciated. :)

RaisinTen
RaisinTen reviewed May 11, 2021
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
Trott
Trott reviewed May 12, 2021
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
@ihiteshsharma @Trott
Update doc/api/fs.md
92e1918 
Co-authored-by: Rich Trott <rtrott@gmail.com>
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 15, 2021
jasnell pushed a commit that referenced this pull request May 17, 2021
@ihiteshsharma @jasnell
doc: add documentation for fs.WriteStream.close()
5b90748 
PR-URL: #38610
Fixes: #38606
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@jasnell
Copy link
Member

jasnell commented May 17, 2021

Landed in 5b90748

@jasnell jasnell closed this May 17, 2021
targos pushed a commit that referenced this pull request May 18, 2021
@ihiteshsharma @targos
doc: add documentation for fs.WriteStream.close()
0100a3b 
PR-URL: #38610
Fixes: #38606
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request May 18, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@ihiteshsharma @targos
doc: add documentation for fs.WriteStream.close()
a44219d 
PR-URL: #38610
Fixes: #38606
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex mscdex left review comments

@RaisinTen RaisinTen RaisinTen approved these changes

@marsonya marsonya marsonya approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: Missing instance method for fs.createWriteStream()
7 participants
@ihiteshsharma @jasnell @mscdex @Trott @marsonya @RaisinTen @targos