Skip to content

Conversation

@RaisinTen
Copy link
Member

The name ‘gnu++1y’ is deprecated.

Refs: https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html

@github-actions github-actions bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels May 2, 2021
@addaleax
Copy link
Member

addaleax commented May 2, 2021

@RaisinTen Do you know the gcc version which introduced the gnu++14 spelling?

@RaisinTen
Copy link
Member Author

@addaleax I think it was introduced in gcc-5.1.0.
gcc-4.9.4 only has support for the -std=gnu++1y option:
https://gcc.gnu.org/onlinedocs/gcc-4.9.4/gcc/C-Dialect-Options.html#C-Dialect-Options
And the next version, gcc-5.1.0, allows -std=gnu++14 as well:
https://gcc.gnu.org/onlinedocs/gcc-5.1.0/gcc/C-Dialect-Options.html#C-Dialect-Options

@addaleax
Copy link
Member

addaleax commented May 3, 2021

Cool, then I’d say we don’t land this on LTS branches because some people probably still find their way of building with gcc 4.9, but this should be fine 👍

@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 3, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 3, 2021

@jasnell jasnell added fast-track PRs that do not need to wait for 48 hours to land. and removed needs-ci PRs that need a full CI run. fast-track PRs that do not need to wait for 48 hours to land. labels May 4, 2021
@jasnell
Copy link
Member

jasnell commented May 4, 2021

Landed in f9d6de4

@jasnell jasnell closed this May 4, 2021
jasnell pushed a commit that referenced this pull request May 4, 2021
The name ‘gnu++1y’ is deprecated.

Refs: https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html

PR-URL: #38504
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@nodejs nodejs deleted a comment from github-actions bot May 4, 2021
@RaisinTen RaisinTen deleted the build/compile-with-std=gnu++14 branch May 5, 2021 13:53
targos pushed a commit that referenced this pull request May 17, 2021
The name ‘gnu++1y’ is deprecated.

Refs: https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html

PR-URL: #38504
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants