lib: harden lint checks for globals#38419
Closed
aduh95 wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
github-actions
bot
added
lib / src
Contributor
Author
|
@nodejs/linting wdyt? |
jasnell
approved these changes
Apr 28, 2021
This comment has been minimized.
This comment has been minimized.
aduh95
added
the
author ready
RaisinTen
approved these changes
Apr 28, 2021
Collaborator
Member
|
Landed in 7919ced |
jasnell
pushed a commit
that referenced
this pull request
Apr 28, 2021
PR-URL: #38419 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
PR-URL: #38419 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Jul 19, 2021
PR-URL: nodejs#38419 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Member
|
Backported to v14.x-staging in #39448. |
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
PR-URL: nodejs#38419 Backport-PR-URL: nodejs#39448 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Feb 16, 2022
bengl
pushed a commit
to bengl/node
that referenced
this pull request
Feb 21, 2022
Refs: nodejs#38230 Refs: nodejs#38419 PR-URL: nodejs#42014 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
bengl
pushed a commit
to bengl/node
that referenced
this pull request
Feb 21, 2022
Refs: nodejs#38230 Refs: nodejs#38419 PR-URL: nodejs#42014 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In most cases we want to avoid relying of looking up the global scope to access an API, which could be mutated from userland.