perf_hooks: fix PerformanceObserver 'gc' crash #38414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: nodejs#38412
This comment has been minimized.
This comment has been minimized.
targos
approved these changes
Apr 26, 2021
aduh95
approved these changes
Apr 26, 2021
jasnell
added
author ready
addaleax
approved these changes
Apr 26, 2021
richardlau
approved these changes
Apr 26, 2021
|
CI is green and this has plenty of signoff. It shouldn't need to wait the full 48 hours to land. Please 👍🏻 to fast-track. |
Lxxyx
approved these changes
Apr 27, 2021
|
Landed in ea01548 |
jasnell
added a commit
that referenced
this pull request
Apr 27, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: #38412 PR-URL: #38414 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: #38412 PR-URL: #38414 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #38412