Merged
Conversation
cjihrig
approved these changes
Apr 15, 2021
targos
approved these changes
Apr 15, 2021
RaisinTen
approved these changes
Apr 15, 2021
Member
|
Unrelated github CI failure. Will land once we get a good run. |
marsonya
approved these changes
Apr 15, 2021
richardlau
approved these changes
Apr 15, 2021
lpinca
approved these changes
Apr 15, 2021
VoltrexKeyva
approved these changes
Apr 15, 2021
Trott
approved these changes
Apr 17, 2021
"alterered" -> "altered" PR-URL: nodejs#38243 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
faf4e36 to
fb93b71
Compare
Contributor
|
Landed in fb93b71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a typo in buffer documentation :
alterered -> altered