test: replace function with arrow function and remove unused argument#38235
Closed
andresatencio wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
needs-ci
yashLadha
approved these changes
Apr 14, 2021
PoojaDurgad
approved these changes
Apr 14, 2021
HarshithaKP
approved these changes
Apr 14, 2021
benjamingr
approved these changes
Apr 14, 2021
Trott
approved these changes
Apr 14, 2021
RaisinTen
approved these changes
Apr 14, 2021
Collaborator
RaisinTen
added
the
author ready
cjihrig
approved these changes
Apr 14, 2021
lpinca
approved these changes
Apr 14, 2021
jasnell
approved these changes
Apr 14, 2021
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
This passed CI and has plenty of signoff. There's no reason to make it wait the full 48 hours to land. Please 👍🏻 to fast-track
jasnell
added
fast-track
andresatencio
force-pushed
the
andresatencio/test-readline-replace-function-to-arrow-function
branch
from
c078efb to
91a3e45
Compare
aduh95
approved these changes
Apr 17, 2021
Collaborator
Collaborator
Collaborator
PR-URL: nodejs#38235 Reviewed-By: Yash Ladha <yash@yashladha.in> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
andresatencio/test-readline-replace-function-to-arrow-function
branch
from
91a3e45 to
4243ce0
Compare
Contributor
|
Landed in 4243ce0. Thanks for the contribution 🎉 |
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
PR-URL: #38235 Reviewed-By: Yash Ladha <yash@yashladha.in> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
PR-URL: #38235 Reviewed-By: Yash Ladha <yash@yashladha.in> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #38235 Reviewed-By: Yash Ladha <yash@yashladha.in> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #38235 Reviewed-By: Yash Ladha <yash@yashladha.in> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace function with arrow function and remove unused argument (line)
Checklist