lib: add JSDoc to os module functions#38197
Closed
xavdid wants to merge 3 commits intonodejs:masterfrom
xavdid:xavdid-types-os
Closed
lib: add JSDoc to os module functions#38197xavdid wants to merge 3 commits intonodejs:masterfrom xavdid:xavdid-types-os
xavdid wants to merge 3 commits intonodejs:masterfrom
xavdid:xavdid-types-os
Conversation
nodejs-github-bot
added
needs-ci
Member
|
cc @bmeck |
bmeck
reviewed
Apr 12, 2021
bmeck
reviewed
Apr 12, 2021
bmeck
approved these changes
Apr 12, 2021
Member
bmeck
left a comment
bmeck
left a comment
There was a problem hiding this comment.
LGTM, after nits on the parameters
add param types Co-authored-by: Bradley Farias <bradley.meck@gmail.com>
Contributor
Author
|
Ah, good catch! Sorry about that. |
targos
reviewed
Apr 13, 2021
targos
reviewed
Apr 13, 2021
Co-authored-by: Michaël Zasso <targos@protonmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
benjamingr
approved these changes
Apr 14, 2021
Collaborator
jasnell
added
author ready
jasnell
approved these changes
Apr 16, 2021
targos
pushed a commit
that referenced
this pull request
Apr 18, 2021
PR-URL: #38197 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Member
|
Landed in d97787f |
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #38197 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
PR-URL: #38197 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by @bmeck: https://twitter.com/bradleymeck/status/1380643627211354115
I only pulled in actual docs if it seemed relevant, but can add more. It seemed redundant to copy the docs wholesale, but I can!
I also wasn't sure what the preferred style for types was with regards to
x[]vsArray<x>, so I went with the recommended array-simple mode oftypescript-eslint.Some screenshots: