test: fix flaky timeout-request body and headers tests #38045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
benjamingr
approved these changes
Apr 2, 2021
|
@nodejs/testing |
Linkgoron
added
the
flaky-test
Linkgoron
changed the title
|
Added the same fix to 3 other tests that check |
Linkgoron
force-pushed
the
test-delayed-timeout-flaky-tests
branch
from
adf4624
to
3b82eee
Compare
benjamingr
approved these changes
Apr 3, 2021
Linkgoron
added
the
author ready
Trott
approved these changes
Apr 5, 2021
fix the flaky test-http-server-request-timeout-delayed-body and test-http-server-request-timeout-delayed-headers which sometimes fail on slow systems. PR-URL: nodejs#38045 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
force-pushed
the
test-delayed-timeout-flaky-tests
branch
from
3b82eee
to
d75543d
Compare
|
Landed in d75543d |
targos
pushed a commit
that referenced
this pull request
May 1, 2021
fix the flaky test-http-server-request-timeout-delayed-body and test-http-server-request-timeout-delayed-headers which sometimes fail on slow systems. PR-URL: #38045 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the flaky
test-http-server-request-timeout-delayed-bodyandtest-http-server-request-timeout-delayed-headerstests which sometimes fail on slow systems. This happened to me today on the raspberry pi CI, and I could reproduce this locally by running/tools/test.py -j250 --repeat=1000 test/parallel/test-http-server-request-timeout-delayed-body.js. I could not reproduce the issue after my fix.The reason, I believe, is that sometimes it takes more than a second for the request to "reach" the server. I've changed the tests to delay the body/headers sending to only happen when we're sure that a connection was made with the server.
EDIT:
Also added the same fix to:
test/parallel/test-http-server-request-timeout-interrupted-body.jstest/parallel/test-http-server-request-timeout-interrupted-headers.jstest/parallel/test-http-server-request-timeout-upgrade.js