test: improve clarity of test-async-local-storage-enable-disable.js \… #38008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
|
Please adapt the commit message to follow the guideline - it's too long for a headline. |
The last als.run() will reactivate the als, hence the test should test for getting the object, not undefined
PhakornKiong
force-pushed
the
refactor/test
branch
from
0683286 to
7920390
Compare
|
@Flarna I've updated the commit message. |
Flarna
approved these changes
Apr 1, 2021
Flarna
added
the
author ready
jasnell
approved these changes
Apr 1, 2021
cjihrig
approved these changes
Apr 2, 2021
Flarna
pushed a commit
that referenced
this pull request
Apr 2, 2021
The last als.run() will reactivate the als, hence the test should test for getting the object, not undefined PR-URL: #38008 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in e46c680 |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 4, 2021
The last als.run() will reactivate the als, hence the test should test for getting the object, not undefined PR-URL: #38008 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
The last als.run() will reactivate the als, hence the test should test for getting the object, not undefined PR-URL: #38008 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last als.run() will reactivate the als, hence the test should test for getting the object, not
undefinedBased on the Nodejs documentation
The original test is doing
The
asyncLocalStorage.getStore()will return aMap, however, the test will pass as it is not strict.As this is within a
run(), we should test forasyncLocalStorageto return thestoreinstead.This will demonstrate a clearer purpose of the test.