test: refactor code to use AbortSignal.abort() #37798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
jasnell
approved these changes
Mar 18, 2021
marsonya
approved these changes
Mar 18, 2021
aduh95
added
the
author ready
lpinca
approved these changes
Mar 18, 2021
Lxxyx
approved these changes
Mar 19, 2021
|
Looks like some workers terminated due to reaching memory limit on Jenkins. |
himself65
approved these changes
Mar 19, 2021
PR-URL: nodejs#37798 Refs: whatwg/dom#960 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
aduh95
force-pushed
the
refactor-use-abortsignal-abort
branch
from
722516a
to
eaadc4b
Compare
|
Landed in eaadc4b |
|
Congrats on your first core contribution 🎉 |
|
Thank you @benjamingr for being a great mentor! |
ruyadorno
pushed a commit
that referenced
this pull request
Mar 24, 2021
PR-URL: #37798 Refs: whatwg/dom#960 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @benjamingr, I refactored all code that used pre-aborted signals to the new API
AbortSignal.abort()by @jasnell.Refs: whatwg/dom#960