[v12.x] node-api: define version 8#37796
Merged
richardlau merged 1 commit intonodejs:v12.x-stagingfrom Mar 19, 2021
Merged
Conversation
gabrielschulhof
added
c++
gabrielschulhof
requested review from
Flarna,
MylesBorins,
addaleax,
codebytere,
legendecas and
mhdawson
nodejs-github-bot
added
lib / src
Flarna
approved these changes
Mar 18, 2021
Collaborator
Merged
Collaborator
Collaborator
richardlau
approved these changes
Mar 18, 2021
BethGriggs
approved these changes
Mar 18, 2021
Collaborator
legendecas
approved these changes
Mar 19, 2021
Mark as stable the APIs that define Node-API version 8. PR-URL: nodejs#37652 Backport-PR-URL: nodejs#37796 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
richardlau
force-pushed
the
backport-node-api-8-to-v12.x
branch
from
8a3773b to
93dd799
Compare
Member
|
Landed in 93dd799 |
This was referenced Apr 18, 2023
This was referenced Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark as stable the APIs that define Node-API version 8.
PR-URL: #37652
Reviewed-By: @Flarna
Reviewed-By: @mhdawson
Reviewed-By: @legendecas