Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fixup flaky test-crypto-x509 #37709

Closed
wants to merge 1 commit into from
Closed

test: fixup flaky test-crypto-x509 #37709

wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Mar 11, 2021

👍🏻 to fast-track

/cc @jasnell

@panva panva added test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 11, 2021
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 11, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36610/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36613/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36615/

@panva
Copy link
Member Author

panva commented Mar 11, 2021

Landed in 8283373

@panva panva closed this Mar 11, 2021
panva added a commit that referenced this pull request Mar 11, 2021
@panva
test: fixup flaky test-crypto-x509
8283373 
PR-URL: #37709
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 mentioned this pull request Mar 13, 2021
Merged
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@panva @danielleadams
test: fixup flaky test-crypto-x509
7fd2a69 
PR-URL: #37709
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@panva @danielleadams
test: fixup flaky test-crypto-x509
ed32cd4 
PR-URL: #37709
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva panva deleted the deflake-x509 branch October 13, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panva @nodejs-github-bot @lpinca @aduh95 @targos