event: remove return value on addEventListener #37696
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
benjamingr
approved these changes
Mar 10, 2021
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
Good catch. Add a test probably?
Flarna
approved these changes
Mar 10, 2021
jasnell
added
events
This comment has been minimized.
This comment has been minimized.
The `addEventListener()` should not return a value. Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
dont-return-from-addeventlistener
branch
from
817c0da to
a532ad6
Compare
jasnell
added
the
author ready
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
trivikr
approved these changes
Mar 12, 2021
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
Mar 12, 2021
Collaborator
Flarna
pushed a commit
that referenced
this pull request
Mar 13, 2021
The `addEventListener()` should not return a value. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37696 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in ef459d8 |
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
The `addEventListener()` should not return a value. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37696 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
The `addEventListener()` should not return a value. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37696 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
addEventListener()should not return a value.Signed-off-by: James M Snell jasnell@gmail.com
/cc @benjamingr